Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTK_STATIC_TRANSLATION is set by default. #81

Merged
merged 1 commit into from
Oct 19, 2023
Merged

DTK_STATIC_TRANSLATION is set by default. #81

merged 1 commit into from
Oct 19, 2023

Conversation

wangling12
Copy link
Contributor

Because the store strictly limits the installation path of third-party applications. Adding this path may simplify third-party application development.

kegechen
kegechen reviewed Jun 23, 2021
View reviewed changes
Copy link
Contributor

@kegechen kegechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add DTK_STATIC_TRANSLATION=YES to add support for static translations

try DTK_STATIC_TRANSLATION ?

@wangling12
Copy link
Contributor Author

Add DTK_STATIC_TRANSLATION=YES to add support for static translations

try DTK_STATIC_TRANSLATION ?

这个宏未打开，默认情况下无法使用应用无法使用，或许可以和以下修复一起，默认打开该功能？
linuxdeepin/dtkcommon#1

@wangling12 wangling12 changed the title add :/translations in loadTranslator path DTK_STATIC_TRANSLATION is set by default. Jun 29, 2021
@wangling12 wangling12 requested a review from kegechen August 10, 2021 08:57
zccrs
zccrs requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@zccrs zccrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to reply to you now, we have migrated the dtkcommon project to github for development, thank you for the PR, but it needs to be rebase to be merged, can you do it?

github-actions[bot]
github-actions bot reviewed May 30, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

Bravo!

github-actions[bot]
github-actions bot reviewed May 30, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck Result

Neat Work!

@asterwyx asterwyx requested a review from zccrs January 18, 2023 03:37
@github-actions
Copy link

github-actions bot commented Jan 18, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@asterwyx
Copy link
Contributor

请按照我合并的commit rebase代码, 并且合并成一个提交, 重新触发ci.

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 18, 2023

Doc Check bot
🟢 Document Coverage Check Passed!

@wangling12
Copy link
Contributor Author

还有人在看呢啊，是不是我是唯一一个在看这个的

请按照我合并的commit rebase代码, 并且合并成一个提交, 重新触发ci.

rebase了，之前提交这个是因为试图用dtk开发并上架商店的话，翻译文件根本没地方放置。不确定这个问题是否依旧存在。。。 😂😂

asterwyx
asterwyx reviewed Jan 18, 2023
View reviewed changes
debian/rules Outdated Show resolved Hide resolved
@asterwyx
Copy link
Contributor

还有人在看呢啊，是不是我是唯一一个在看这个的

请按照我合并的commit rebase代码, 并且合并成一个提交, 重新触发ci.

rebase了，之前提交这个是因为试图用dtk开发并上架商店的话，翻译文件根本没地方放置。不确定这个问题是否依旧存在。。。 joyjoy

静态翻译功能代码里面还是存在的,这个PR可以合并.我近期在处理dtkwidget的重构,顺便清理一下旧的PR.

zccrs
zccrs previously approved these changes Jan 18, 2023
View reviewed changes
asterwyx
asterwyx previously approved these changes Jan 31, 2023
View reviewed changes
@hudeng-go
Copy link

/check build-deb

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 5, 2023

Deepin ChatOps Bot
Deepin redeliveried failed, need update or recreate pull request!!!

@kegechen
Copy link
Contributor

approved了多次，又冲突了。approved 之后及时 merge（回复 /merge 即可） @wangling12

@wangling12
Copy link
Contributor Author

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 17, 2023

This pr cannot be merged! (status: blocked)

@wangling12
Copy link
Contributor Author

哥，这个自动化流程好高端 🤣 🤣

@asterwyx
Copy link
Contributor

哥，这个自动化流程好高端 🤣 🤣

签一下CLA吧，回复/recheck

asterwyx
asterwyx previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@asterwyx asterwyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请签署CLA。

@asterwyx
Copy link
Contributor

好像rebase还有问题，先手动rebase一下吧，只留一个commit。

@wangling12
feat: change DTK_STATIC_TRANSLATION to the default setting.
a3d5422 
change DTK_STATIC_TRANSLATION to the default setting.
默认设置DTK_STATIC_TRANSLATION,以便第三方dtk应用可以较方便携带翻译文件
@wangling12
Copy link
Contributor Author

/recheck

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: asterwyx, wangling12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot merged commit f5d75bf into linuxdeepin:master Oct 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@asterwyx asterwyx asterwyx approved these changes

@zccrs zccrs zccrs left review comments

@kegechen kegechen Awaiting requested review from kegechen

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wangling12 @asterwyx @hudeng-go @kegechen @deepin-ci-robot @zccrs