Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: border line isn't updated at dpi is 1.25 #626

Closed
wants to merge 1 commit into from

Conversation

FeiWang1119
Copy link
Contributor

actively update the view when clicking the item

pms: BUG-286533

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FeiWang1119 FeiWang1119 requested a review from kegechen December 11, 2024 08:00
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 11, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#626
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 12, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#626
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • eventFilter函数中,Q_FALLTHROUGH()宏的使用可能不正确,因为它没有在所有情况下都执行,可能会导致逻辑错误。
  • view->update();调用可能会引起不必要的界面刷新,应该考虑是否有更高效的方法来更新视图。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 12, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#626
actively update the view when clicking the item

pms: BUG-286533
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 12, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants