Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move ddesktopservices to dtkgui #537

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

kegechen
Copy link
Contributor

move ddesktopservices from dtkwidget to dtkgui

Issue: linuxdeepin/dtk#134

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Nov 10, 2023
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#537
@kegechen kegechen requested a review from asterwyx November 10, 2023 08:25
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Nov 10, 2023
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#537
18202781743
18202781743 previously approved these changes Nov 10, 2023
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Nov 13, 2023
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#537
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 13, 2023

Doc Check bot
🟢 Document Coverage Check Passed!

Copy link
Contributor

@asterwyx asterwyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个看起来是和DBus相关的逻辑,需要放在Gui里面吗?

@kegechen
Copy link
Contributor Author

这个看起来是和DBus相关的逻辑,需要放在Gui里面吗?

dtkgui中也有也有dbus调用的,如果quick应用(launchpad)想用就需要放到gui中而不是widget中

move ddesktopservices from dtkwidget to dtkgui

Issue: linuxdeepin/dtk#134
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Nov 13, 2023
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#537
@kegechen
Copy link
Contributor Author

/check obs

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 15, 2023

Deepin Obs Bot
Deepin redeliveried failed, need update or recreate pull request!!!

@kegechen kegechen merged commit 1350535 into linuxdeepin:master Nov 28, 2023
15 checks passed
kegechen pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Nov 29, 2023
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants