-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update docs for dcombobox #473
Conversation
Doc Check bot |
docs/widgets/dcombobox.zh_CN.dox
Outdated
TODO: 添加类简介、示例代码、示例截图和函数使用说明等 | ||
@class Dtk::Widget::DComboBox | ||
@brief DComboBox 重写QComboBox, 提供一个下拉列表供用户选择 | ||
@note@row 代码示例 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码示例可以用@code
docs/widgets/dcombobox.zh_CN.dox
Outdated
*/ | ||
@fn void DComboBox::showPopup() | ||
@brief 重写QComboBox::showPopup, 按照maxVisibleItems()来限制最大显示高度,其值默认为16,可通过setMaxVisibleItems()来改变最大显示高度,这个功能使得setMaximumHeight()接口无效。 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
文件结尾需要空行
src/widgets/dcombobox.cpp
Outdated
@@ -145,7 +145,7 @@ void DComboBox::showPopup() | |||
} | |||
return count; | |||
}; | |||
// 小于 16 的时候使用 qt 默认的,直接返回,避免显示多余的空白 | |||
// When the value of maxVisibleItems() is less than 16, use the default value provided by Qt and return directly to avoid displaying extra blank space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个翻译可以改改,不然一眼看上去一头雾水
更新dcombobox文档 Log: update docs Issue: linuxdeepin/dtk#94 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
debian 环境异常,本次手动合并。 |
@@ -45,7 +45,8 @@ void DComboBoxPrivate::init() | |||
} | |||
|
|||
/*! | |||
* \~chinese \brief 获得控件屏幕矩形位置,QDesktopWidgetPrivate改为QApplication::desktop()访问应用位置。 | |||
* @~english | |||
@brief Obtain the screen rectangle position of the control, replace QDesktopWidgetPrivate with QApplication::desktop() to access the application position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obtain the screen rectangle of the widget. Use QScreen to access the screen geometry.
更新dcombobox文档
Log: update docs
Issue: linuxdeepin/dtk#94 (comment)