Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iterator out of bounds for dciicon #293

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

18202781743
Copy link
Contributor

Add check.

pms: TASK-368399

Add check.

pms: TASK-368399
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#293
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • loadIconList函数中,新增的continue语句可能会改变原有逻辑,需要确认这是否是预期的行为。
  • tryMatchIcon函数中,修改了if语句的条件判断,增加了对targetIcon是否为iconWeight.constEnd()的检查,这是一个好的做法,可以避免在iconWeight为空时访问越界。

是否建议立即修改:

  • 是,需要确认loadIconList函数中新增的continue语句是否符合预期,并确保tryMatchIcon函数的修改不会引入新的逻辑错误。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit acd947f into linuxdeepin:master Dec 27, 2024
22 of 24 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 27, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants