Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crashed in x11 #254

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: app crashed in x11 #254

merged 1 commit into from
Aug 30, 2024

Conversation

18202781743
Copy link
Contributor

Missing check for Treeland.

TODO: CreatorWindowEventFile should distinguish between X11 and
Treeland.

Missing check for Treeland.

TODO: CreatorWindowEventFile should distinguish between X11 and
Treeland.
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • isTreeLand函数中,环境变量的读取使用了硬编码的字符串"DDE_CURRENT_COMPOSITOR",建议使用常量或配置文件来管理环境变量名。
  • isTreeLand函数的命名不够明确,建议使用更具描述性的名称,如isCurrentCompositorTreeLand
  • setEnabledNoTitlebarForWindow函数中,对isTreeLand的调用被移除,如果这是有意为之,应确保相关逻辑得到正确处理。
  • setWindowProperty函数中,对windowname的类型转换没有进行错误检查,可能会导致运行时错误。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Aug 30, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#254
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, justforlxz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 30, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@18202781743 18202781743 merged commit 8cf037d into linuxdeepin:master Aug 30, 2024
20 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Aug 30, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants