Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(power)!: switch backend from lmt to tlp #559

Closed
wants to merge 1 commit into from
Closed

feat(power)!: switch backend from lmt to tlp #559

wants to merge 1 commit into from

Conversation

Decodetalkers
Copy link
Contributor

Log:

@Decodetalkers Decodetalkers force-pushed the switchtotlp branch 3 times, most recently from 7469f0a to 414b5e4 Compare September 25, 2023 03:49
@Decodetalkers Decodetalkers reopened this Sep 25, 2023
@Decodetalkers
Copy link
Contributor Author

@xzl01

dengbo11
dengbo11 requested changes Sep 28, 2023
View reviewed changes
system/power1/manager_bluetoothadapter.go
"os/exec"
"regexp"
"strings"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加空行，下面几处同理

system/power1/manager_powersave.go Outdated
return
}
var enable bool
// var tlpCfgChanged bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要的变量删掉

system/power1/manager_tlp.go Outdated
"os/exec"
"path/filepath"
"strings"
//"github.com/linuxdeepin/go-lib/dbusutil"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要的包删掉

system/power1/manager_tlp.go Outdated
if os.IsNotExist(err) {
return false, nil
}
logger.Warning(err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行可以移到65行

system/power1/manager.go
@@ -803,3 +824,12 @@ func (m *Manager) doSetCpuGovernor(governor string) error {
}
return err
}

func (m *Manager) setPowerSavingModeEnabled(enable bool) (changed bool) {
changed = m.setPropPowerSavingModeEnabled(enable)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果这个属性没有change, 是否还需要写呢

system/power1/manager_powersave.go Outdated
import (
"errors"
"github.com/godbus/dbus/v5"
ConfigManager "github.com/linuxdeepin/go-dbus-factory/org.desktopspec.ConfigManager"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConfigManager小写命名

system/power1/manager.go
@@ -694,7 +715,7 @@ func (m *Manager) doSetMode(mode string) error {
break
}

m.setPropPowerSavingModeEnabled(false)
m.setPowerSavingModeEnabled(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是否需要加锁，下面两处同理

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯，我看powersave那边也加锁了，那这边确实要加锁

@Decodetalkers Decodetalkers force-pushed the switchtotlp branch 2 times, most recently from 6ee7982 to 7a259f6 Compare September 28, 2023 05:04
dengbo11
dengbo11 previously approved these changes Oct 7, 2023
View reviewed changes
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Decodetalkers

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Decodetalkers
Copy link
Contributor Author

那个锁在manager已经锁了一次了，所以如果再锁就会卡住

@Decodetalkers Decodetalkers marked this pull request as draft October 25, 2023 02:27
@Decodetalkers
Copy link
Contributor Author

需要调研

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 27, 2023

TAG Bot

New tag: 6.0.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #596

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 5, 2024

TAG Bot

New tag: 6.0.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #604

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 17, 2024

TAG Bot

New tag: 6.0.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #609

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 26, 2024

TAG Bot

New tag: 6.0.33
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #613

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 26, 2024

TAG Bot

New tag: 6.0.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #614

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 6, 2024

TAG Bot

New tag: 6.0.35
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dengbo11 dengbo11 dengbo11 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Decodetalkers @deepin-ci-robot @dengbo11