-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(housekeeping): send space warning erery 5 mins #526
base: release/beige
Are you sure you want to change the base?
fix(housekeeping): send space warning erery 5 mins #526
Conversation
This housekeeping module is added because X-org has a problem in XSession script, which cause XSession failed to start when user's home directory is full. Basically, XSession fails because the script redirect std error to ~/.xerrors and failed to write to that file. This bug is fixed in UOS and deepin, by update the XSession script to ignore that write failure. So full of user home directory is not such a big issue now. We can send this warning not that frequently as we used to be, as some users may consider this warning annoying. Related: linuxdeepin/developer-center#4685 Signed-off-by: black-desk <[email protected]>
Need to update this line: to:
|
When user home is full, scripts write to a file in user home will failed. After redirect stdout and stderr to ERRFILE, aka $HOME/.xsession-errors, this script echo a line to that file. This echo might failed and make this script exit with error. In that case, the session leader will not able to even start. Releated: linuxdeepin/developer-center#4685 Releated: linuxdeepin/dde-daemon#526
When user home is full, scripts write to a file in user home will failed. After redirect stdout and stderr to ERRFILE, aka $HOME/.xsession-errors, this script echo a line to that file. This echo might failed and make this script exit with error. In that case, the session leader will not able to even start. Releated: linuxdeepin/developer-center#4685 Releated: linuxdeepin/dde-daemon#526 Signed-off-by: black-desk <[email protected]>
When user home is full, scripts write to a file in user home will failed. After redirect stdout and stderr to ERRFILE, aka $HOME/.xsession-errors, this script echo a line to that file. This echo might failed and make this script exit with error. In that case, the session leader will not able to even start. Releated: linuxdeepin/developer-center#4685 Releated: linuxdeepin/dde-daemon#526 Signed-off-by: black-desk <[email protected]>
@dengbo11 先不合这个 还有其他问题没处理完 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message 和 PR 标题写的都是五分钟,怎么代码是十分钟。。
@@ -50,7 +50,7 @@ func (d *Daemon) Start() error { | |||
return nil | |||
} | |||
|
|||
d.ticker = time.NewTicker(time.Minute * 1) | |||
d.ticker = time.NewTicker(time.Minute * 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d.ticker = time.NewTicker(time.Minute * 10) | |
d.ticker = time.NewTicker(time.Minute * 5) |
因为暂时没打算合这个了,所以一直没更新 |
TAG Bot New tag: 6.0.30 |
TAG Bot New tag: 6.0.31 |
TAG Bot New tag: 6.0.32 |
TAG Bot New tag: 6.0.33 |
TAG Bot New tag: 6.0.34 |
TAG Bot New tag: 6.0.35 |
TAG Bot New tag: 6.0.36 |
TAG Bot New tag: 6.0.37 |
TAG Bot New tag: 6.0.38 |
TAG Bot New tag: 6.0.39 |
TAG Bot New tag: 6.0.40 |
TAG Bot New tag: 6.0.41 |
TAG Bot New tag: 6.0.42 |
TAG Bot New tag: 6.0.43 |
TAG Bot New tag: 6.0.44 |
TAG Bot New tag: 6.0.45 |
TAG Bot New tag: 6.0.46 |
This housekeeping module is added
because X-org has a problem in XSession script,
which cause XSession failed to start
when user's home directory is full.
Basically, XSession fails because
the script redirect std error to ~/.xerrors
and failed to write to that file.
This bug is fixed in UOS and deepin,
by update the XSession script to ignore that write failure.
So full of user home directory is not such a big issue now.
We can send this warning not that frequently as we used to be,
as some users may consider this warning annoying.
Related: linuxdeepin/developer-center#4685
Signed-off-by: black-desk [email protected]