Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inquiry_string to LUN attributes #87

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Add inquiry_string to LUN attributes #87

merged 1 commit into from
Feb 27, 2024

Conversation

NekoCWD
Copy link
Contributor

@NekoCWD NekoCWD commented Feb 22, 2024

Add "inquiry_string" to LUN attributes

What is inquiry_string in LUN attributes?

Inquiry string is a name of LUN which used in SCSI inquiry

For example:

Without inquiry_string (as now)

[timesnap] usb 1-9: new high-speed USB device number 22 using xhci_hcd
[timesnap] usb 1-9: New USB device found, idVendor=1d6b, idProduct=0104, bcdDevice= 0.01
[timesnap] usb 1-9: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[timesnap] usb 1-9: Product: Bar Gadget
[timesnap] usb 1-9: Manufacturer: Foo Inc.
[timesnap] usb 1-9: SerialNumber: 0123456789
[timesnap] usb-storage 1-9:1.0: USB Mass Storage device detected
[timesnap] scsi host6: usb-storage 1-9:1.0
[timesnap] scsi 6:0:0:0: Direct-Access     Linux    File-Stor Gadget 0607 PQ: 0 ANSI: 2
[timesnap] scsi 6:0:0:1: CD-ROM            Linux    File-Stor Gadget 0607 PQ: 0 ANSI: 2

Without inquiry_string (after merging this PR)

[timesnap] usb 1-9: new high-speed USB device number 23 using xhci_hcd
[timesnap] usb 1-9: New USB device found, idVendor=1d6b, idProduct=0104, bcdDevice= 0.01
[timesnap] usb 1-9: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[timesnap] usb 1-9: Product: Bar Gadget
[timesnap] usb 1-9: Manufacturer: Foo Inc.
[timesnap] usb 1-9: SerialNumber: 0123456789
[timesnap] usb-storage 1-9:1.0: USB Mass Storage device detected
[timesnap] scsi host6: usb-storage 1-9:1.0
[timesnap] scsi 6:0:0:0: Direct-Access     Non-empt y                     PQ: 0 ANSI: 2
[timesnap] scsi 6:0:0:1: CD-ROM            Empty                          PQ: 0 ANSI: 2

Solves: #86

@pabs3
Copy link
Member

pabs3 commented Feb 23, 2024 via email

@mgrzeschik
Copy link
Contributor

mgrzeschik commented Feb 26, 2024

Looks good to me. Will you merge @pabs3 ?

@pabs3 pabs3 merged commit a5bfa81 into linux-usb-gadgets:master Feb 27, 2024
@pabs3
Copy link
Member

pabs3 commented Feb 27, 2024

@NekoCWD could you submit a PR for gt to add support for this too?

@NekoCWD
Copy link
Contributor Author

NekoCWD commented Feb 27, 2024

@NekoCWD could you submit a PR for gt to add support for this too?

Shure, i'll do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants