uvc: fix return check on scandir #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function init_frames is falsely checking for the negative result from scandir on an unsigned variable. This will never be true. Signed-off-by: Michael Grzeschik <[email protected]>
|
This patch looks good to me, please merge.
The previous patch fixing the warnings might be incorrect.
The snprintf function returns an int not unsigned.
Please use your own fork to push pull request branches to rather than
using the main repository.
…--
bye,
pabs
https://bonedaddy.net/pabs3/
|
|
I will fix the snprintf unsigned cases. Thanks for pointing them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function init_frames is falsely checking for the negative
result from scandir on an unsigned variable. This will never
be true.
Signed-off-by: Michael Grzeschik [email protected]