Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace docker by podman in the installdeps #166

Closed
wants to merge 1 commit into from

Conversation

RMPR
Copy link

@RMPR RMPR commented Mar 19, 2020

No description provided.

@RMPR RMPR mentioned this pull request Mar 19, 2020
4 tasks
@tyll
Copy link
Member

tyll commented Mar 23, 2020

Why is this a good idea? What problem does it solve?

@richm
Copy link
Contributor

richm commented Mar 23, 2020

Why is this a good idea? What problem does it solve?

It solves the "problem" that we do not want to use docker except where strictly necessary - we want to use podman wherever possible.

@tyll
Copy link
Member

tyll commented Mar 23, 2020

Why is this a good idea? What problem does it solve?

It solves the "problem" that we do not want to use docker except where strictly necessary - we want to use podman wherever possible.

So changing the requirement makes molecule use podman instead of docker? It does not seem to me that it works this way. @RMPR Nevertheless, the justification needs to be added to the commit message. Please follow https://chris.beams.io/posts/git-commit

@RMPR
Copy link
Author

RMPR commented Mar 23, 2020

I don't actually want this to be merged, it is just an illustration of what I tried. See #165

@tyll tyll closed this Mar 23, 2020
@tyll
Copy link
Member

tyll commented Mar 23, 2020

I don't actually want this to be merged, it is just an illustration of what I tried. See #165

Thank you for the clarification. There is no need to file a PR to show this. You can just point to your fork/commit in the issue. Also, if you do not want something to be merged, create it as a draft PR and mention this in the description.

@RMPR
Copy link
Author

RMPR commented Mar 23, 2020

Okay, thanks for the pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants