Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove hard dependency on selinux and firewall roles #154

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

xeluior
Copy link
Contributor

@xeluior xeluior commented Jul 25, 2024

Enhancement: Changes the behavior of the tasks managing selinux and firewall such that if the nbde_server_manage_selinux or nbde_server_manage_firewall variables are false, the appropriate role does not attempt to import.

Reason: I try to only install dependencies I absolutely need in dedicated directories for each project. This change makes it so that the selinux and firewall role dependencies are not needed if their features are not going to be used in that specific project.

Result: Users only need to install this role and not selinux or firewall in order to use this role.

Issue Tracker Tickets (Jira or BZ if any): N/A

…e_server_manage_firewall and/or nbde_server_manage_selinux are false
@richm
Copy link
Contributor

richm commented Jul 25, 2024

Good catch. In general, we should never use import_role in system roles, except in very specific corner cases.

@richm richm changed the title Remove hard dependency on selinux and firewall roles fix: Remove hard dependency on selinux and firewall roles Jul 25, 2024
@richm
Copy link
Contributor

richm commented Jul 25, 2024

[citest]

@richm richm merged commit a20e8f3 into linux-system-roles:main Jul 25, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants