feat: Support mssql-server 2022 preview on RHEL 9 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[citest] |
|
[citest] |
|
lgtm - should the rhel 9.4 tests be passing? |
they must, there is some issue in cleanup. Also, Fedora tests are failing, due to /etc/yum.conf not present on Fedora, I'll fix support for Fedora in another PR to keep things clean. |
|
[citest] |
- Add --noprompt to suppress "This is a preview version" and other messages when setting up mssql server - vars/RedHat.yml for RHEL 9 that only supports SQL Server 2022 - Use tests/tasks/assert_fail_on_unsupported_ver.yml for general version assert
|
[citest] |
|
Setting up mssql on RHEL 9.3 and 9.4 works for me locally. |
|
[citest bad] |
|
[citest] |
|
[citest] |
|
[citest] |
* Add README entry * Add tests_selinux_enforcing.yml to test enforcing * In other tests, for RHEL 9 set mssql_run_selinux_confined and mssql_manage_selinux to `true` * Make the role fail with informative error message when the variables are used on unsupported systems or used with incorrect SELinux mode
|
[citest] |
1 similar comment
|
[citest] |
|
[citest] |
richm
reviewed
Oct 16, 2023
richm
reviewed
Oct 16, 2023
richm
reviewed
Oct 16, 2023
richm
reviewed
Oct 16, 2023
richm
approved these changes
Oct 17, 2023
|
Let's wait with merging until reviews and comments in email thread are resolved. |
|
[citest] |
richm
approved these changes
Nov 13, 2023
|
[citest bad] |
1 similar comment
|
[citest bad] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Support mssql-server 2022 preview on RHEL 9
Reason: Microsoft added SQL Server 2022 preview for RHEL 9 at https://packages.microsoft.com/rhel/9/mssql-server-preview/
Result: You can install SQL Server 2022 on RHEL 9. The role adds two variables:
mssql_run_selinux_confined to control whether to run SQL Server as a confined application or not.
true, the role installs themssql-server-selinuxpackage.false, the role removes themssql-server-selinuxpackage.Default:
truefor RHEL 9 managed nodes andfalsefor not RHEL 9 managed nodesmssql_manage_selinux to control whether to configure SELinux with the
enforcingorpermissivemode based on the value of themssql_run_selinux_confinedvariable.Issue Tracker Tickets (Jira or BZ if any): https://issues.redhat.com/browse/RHELBU-2407