test: delete kdump user last, retry until success #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[citest] |
spetrosi
approved these changes
Sep 12, 2023
Some tests fail like this:
```
TASK [Delete user] *************************************************************
fatal: [/tmp/tmp.cgsy6Vmlnz/RHEL_8_9_TESTING.qcow2]: FAILED! => {
"changed": false,
"name": "kdump_ssh_user",
"rc": 8
}
userdel: user kdump_ssh_user is currently used by process 23050
```
Move the deletion of the user to the last part of the test, and retry
until success or timeout.
Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
retry-user-delete
branch
from
86cacd5 to
ad602df
Compare
spetrosi
reviewed
Sep 13, 2023
| name: "{{ kdump_ssh_user }}" | ||
| state: absent | ||
| register: __user_delete | ||
| until: __user_delete is success |
There was a problem hiding this comment.
The default value for “retries” is 3 and “delay” is 5, is it enough here?
https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_loops.html#retrying-a-task-until-a-condition-is-met
There was a problem hiding this comment.
I think so - the error is very difficult to reproduce in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests fail like this:
Move the deletion of the user to the last part of the test, and retry
until success or timeout.
Signed-off-by: Rich Megginson [email protected]