fix: Ensure authorized_keys management works with multiple hosts #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause: There was a race condition if multiple hosts tried to add a key to the authorized_keys file on kdump_ssh_server at the same time. Consequence: A key added by one host could be overwritten by a key added by another host. Fix: Use the lineinfile module to manage the file - this will ensure that checking for an existing key, and writing the new key, is done in one atomic operation on only one host at a time. Result: A host cannot overwrite the value from another host, and adding keys is idempotent. NOTE: You can use the play keyword `serial: 1` to workaround this issue at the play level. Signed-off-by: Rich Megginson <[email protected]>
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: There was a race condition if multiple hosts tried to add a key
to the authorized_keys file on kdump_ssh_server at the same time.
Consequence: A key added by one host could be overwritten by a key
added by another host.
Fix: Use the lineinfile module to manage the file - this will ensure
that checking for an existing key, and writing the new key, is done
in one atomic operation on only one host at a time.
Result: A host cannot overwrite the value from another host, and adding
keys is idempotent.
NOTE: You can use the play keyword
serial: 1to workaround this issueat the play level.
Signed-off-by: Rich Megginson [email protected]