fix: Write new authorized_keys if needed is not idempotent #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[citest] |
richm
force-pushed
the
authorized_keys-not-idempotent
branch
from
7506037 to
345ef6e
Compare
|
[citest] |
Cause: The new key content had an extra newline at the end. Consequence: The test to see if the new key content was in the current authorized_key list failed, so the key was added every time, and the task was not idempotent. Fix: Ensure the new key value has no extra newline. Use a simple list `in` test to see if the new value is in the existing list. Result: The task to write authorized_keys is idempotent. Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
authorized_keys-not-idempotent
branch
from
345ef6e to
6e03ff3
Compare
|
[citest] |
spetrosi
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: The new key content had an extra newline at the end.
Consequence: The test to see if the new key content was in the
current authorized_key list failed, so the key was added every
time, and the task was not idempotent.
Fix: Ensure the new key value has no extra newline. Use a simple
list
intest to see if the new value is in the existing list.Result: The task to write authorized_keys is idempotent.
Signed-off-by: Rich Megginson [email protected]