tests: Run cleanup on failures as well #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap tests into block:/always: so that the cleanup steps happen on failed tests as well.
|
[citest] |
|
inventory not properly set up again.. (it's empty) |
|
[ci bad] |
|
and don't worry about the CI failures for now (although still having trouble with the git clone of the certificate role is troubling) |
|
All these "empty inventory" tests are also rather worrying.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap tests into block:/always: so that the cleanup steps happen on
failed tests as well.
@richm : As discussed in your meeting last week. My previous PR #46 already uses that approach, this PR retrofits it for the existing tests.