tests: Run integration test in GitHub actions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
force-pushed
the
tests-actions
branch
from
d6ffbdd to
9b180bc
Compare
|
I also ran this on my fork in combination with the extra tests from PR #34. You can see the result in this run. |
martinpitt
commented
Oct 11, 2021
Run them on pull requests, and every Monday morning, to catch regressions in operating systems and outside dependencies.
martinpitt
force-pushed
the
tests-actions
branch
from
9b180bc to
ec65d9b
Compare
|
Sorry for the blocked setting/unsetting -- it pretty well does not matter which one (this or #34) lands first, the other one then needs to be rebased, to make sure that the new checks work in github actions. |
|
Why not do the ubuntu test runs for every PR? That is, why only once per week? |
|
[citest pending] |
It does run for every PR -- you can already see the result right here in the tests. It has two triggers, "on: pull" and "on: cron". |
|
[citest pending] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run them on pull requests, and every Monday morning, to catch
regressions in operating systems and outside dependencies.
This provides feedback for role changes on at least one operating system for outside contributors like me, where the integration tests don't run automatically. It may also help you to remove some of your own custom infra.
If you generally like this, I am happy to work on this some more, and run the test in containers instead (system containers with systemd ought to work well enough these days). Then we can have a test matrix for debian, ubuntu, centos, fedora, and possibly even UBI.