fix: Workaround getcert issue when cert key-file is missing #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
richm
reviewed
Nov 26, 2024
| keyfile = self._certmonger_metadata.get("key-file") | ||
| if keyfile: | ||
| try: | ||
| _fstat = os.stat(keyfile) |
There was a problem hiding this comment.
Instead of os.stat with exception handling, you can do something like
if keyfile and not os.path.exists(keyfile):
self.module.fail_json(
"Resubmiting a request without the private key "
"file may hang certmonger. Please, stop monitoring "
"certificate '{0}' before reissuing.".format(
self._certmonger_metadata.get('nickname')
)
)There was a problem hiding this comment.
I'm not sure I shouldn't process the stat result.
What if the file has been removed and a directory created?
There was a problem hiding this comment.
I'm not sure I shouldn't process the stat result.
What if the file has been removed and a directory created?
ok, but in with the current code, _fstat is not used, and CodeQL flags it
There was a problem hiding this comment.
I change to use os.path.isfile. More than that and we would be looking into the file content, which I believe is way out of scope here.
When trying to resubmit a certificate request that had the key file removed, "getcert" hangs indefinitely, causing the role to not respond. This workaround checks if the private key file has been removed and fails ressubmiting the certificate request until the situation is fixed, by the user, using 'getcert stop-tracking --id <cert ID>'.
rjeffman
force-pushed
the
fix_rhel13333
branch
from
a6ee37c to
76221c7
Compare
rjeffman
changed the title
|
[citest] |
richm
approved these changes
Nov 26, 2024
|
looks like the Fedora failures are unrelated (problem with ipa?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to resubmit a certificate request that had the key file removed, "getcert" hangs indefinitely, causing the role to not respond.
This workaround checks if the private key file has been removed and fails ressubmiting the certificate request until the situation is fixed, by the user, using 'getcert stop-tracking --id '.
Issue Tracker Tickets (Jira or BZ if any): RHEL-13333