Skip to content

Commit

Permalink
mfd: intel-lpss: use devm_ioremap_uc for MMIO
Browse files Browse the repository at this point in the history
Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci
in MTRR. This will cause the system to hang during boot. If possible,
this bug could be corrected with a firmware update.

This patch use devm_ioremap_uc to overwrite/ignore the MTRR settings
by forcing the use of strongly uncachable pages for intel-lpss.

The BIOS bug is present on Dell XPS 13 7390 2-in-1:

[    0.001734]   5 base 4000000000 mask 6000000000 write-combining

4000000000-7fffffffff : PCI Bus 0000:00
  4000000000-400fffffff : 0000:00:02.0 (i915)
  4010000000-4010000fff : 0000:00:15.0 (intel-lpss-pci)

Link: https://bugzilla.kernel.org/show_bug.cgi?id=203485
Cc: <[email protected]>
Tested-by: AceLan Kao <[email protected]>
Signed-off-by: Tuowen Zhao <[email protected]>
Acked-by: Mika Westerberg <[email protected]>
Acked-by: Andy Shevchenko <[email protected]>
Acked-for-MFD-by: Lee Jones <[email protected]>
Tested-by: Roman Gilg <[email protected]>
  • Loading branch information
ztuowen authored and qzed committed Dec 9, 2019
1 parent 04f6483 commit f3e1eb2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/mfd/intel-lpss.c
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ int intel_lpss_probe(struct device *dev,
if (!lpss)
return -ENOMEM;

lpss->priv = devm_ioremap(dev, info->mem->start + LPSS_PRIV_OFFSET,
lpss->priv = devm_ioremap_uc(dev, info->mem->start + LPSS_PRIV_OFFSET,
LPSS_PRIV_SIZE);
if (!lpss->priv)
return -ENOMEM;
Expand Down

0 comments on commit f3e1eb2

Please sign in to comment.