Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments in the config around {low,high,max}_temp settings #232

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

hyperair
Copy link

@hyperair hyperair commented Mar 2, 2021

Amend the comments in mbpfan.conf around low_temp, high_temp, and max_temp to convey more information about what these settings actually are. The meaning was derived from the comments in this region:

mbpfan/src/mbpfan.c

Lines 57 to 59 in 52d8973

* low_temp - temperature below which fan speed will be at minimum
* high_temp - fan will increase speed when higher than this temperature
* max_temp - fan will run at full speed above this temperature */

Fixes: #203

@gaul gaul merged commit 16f28f9 into linux-on-mac:master Mar 2, 2021
@gaul
Copy link
Member

gaul commented Mar 2, 2021

Thank you for your contribution @hyperair!

@hyperair hyperair deleted the better-docs-in-config branch March 2, 2021 14:42
@hyperair
Copy link
Author

hyperair commented Mar 2, 2021

You're welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix/improvement suggestion (fan's speed adjustment fault)
2 participants