-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect minimum and maximum fan speeds #137
Conversation
I think we need to add an option to |
Ideally mbpfan should work without any configuration file. I plan a subsequent commit which will make intelligent decisions about the temperatures. |
Currently on vacation. Will try to review all these PR by the end of the month. I would like more the generation of a config file than to go config-less. Still give power to end user to override. |
Agree that the user should be able to override the defaults, but I would like the defaults to be dynamic instead of static as today. |
@gaul how about having a flag to create a default config file instead? That would use your smart detection system and would make the user more aware of what is going on. |
db90962
to
b9c6e81
Compare
mbpfan should not need a config file for typical users and only use it for unusual situations. macOS users do not need a config file to get reasonable behavior from their fans! |
@dgraziotin I would like to merge this; any objections? |
b9c6e81
to
2a12d5b
Compare
Unfortunately Better Code Hub does not allow me to view this error:
@dgraziotin Perhaps you can configure open access somehow? |
@gaul I will take a look. Isn't BCH not suitable for C, though? I will look whether I can make the results open for anyone |
Sorry I don't understand what is BCH? |
2a12d5b
to
628eebb
Compare
Default to previous values if detection fails. Configuration can still override these values. Fixes linux-on-mac#114.
628eebb
to
967d978
Compare
Default to previous values if detection fails. Configuration can
still override these values. Fixes #114.