ioctl,types: telemetry log update based NVMe v2.1 #922
+49
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Dec 2, 2024
| @@ -1548,7 +1564,7 @@ static inline int nvme_get_log_create_telemetry_host(int fd, | |||
| .nsid = NVME_NSID_NONE, | |||
| .csi = NVME_CSI_NVM, | |||
| .lsi = NVME_LOG_LSI_NONE, | |||
| .lsp = NVME_LOG_TELEM_HOST_LSP_CREATE, | |||
| .lsp = (__u8)((mcda << 1) | NVME_LOG_TELEM_HOST_LSP_CREATE), | |||
There was a problem hiding this comment.
I assume this is the thing which 5.1.12.1.8 Telemetry Host-Initiated (Log Page Identifier 07h) talks about:
If the MCDAS bit (refer to Figure 215) is set to ‘1’ and a Get Log Page command with the Create Telemetry
Host-Initiated Data bit is set to ‘1’, then the maximum data area to be created in the Telemetry Host-Initiated
log page shall be less than or equal to the MCDA field in the Log Specific Parameter field in Command
Dword 10 (refer to Figure 213).
Is my understanding correct?
|
looks good, just a bit confused how this api works. |
sc108-lee
force-pushed
the
telemetry
branch
2 times, most recently
from
095560a
to
d09ca0f
Compare
MCDA added for Telemetry Host-Initiated Log creation Log member variable added Host-Initiated Log - THS Controller-Initiated Log - TCS Signed-off-by: Steven Seungcheol Lee <[email protected]>
|
Actually I was considering api problem, same as you. remain : old function to call new function |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCDA added for Telemetry Host-Initiated Log creation
Log member variable added
Host-Initiated Log - THS
Controller-Initiated Log - TCS