types: Update id-ctrl field based on NVMe 2.1 spec #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @NVME_CTRL_BACAP_SFBPWPS: Set Features Boot Partition Write Protection Support | ||
| */ | ||
| enum nvme_id_ctrl_bpcap { | ||
| NVME_CTRL_BACAP_RPMBBPWPS = 3 << 0, |
There was a problem hiding this comment.
Should these be _MASK and _SHIFT fields so we use the NVME_GET and NVME_SET macros?
And then include actual values for various RPMBBPWPS
There was a problem hiding this comment.
Yes, please introduce the _MASK and _SHIFT fields.
Boot Partition Capabilities (BPCAP) NVM Subsystem Shutdown Latency (NSSL) Power Loss Signaling Information (PLSI) Controller Reachability Capabilities (CRCAP) Key Per I/O Capabilities (KPIOC) Maximum Processing Time for Firmware Activation Without Reset (MPTFAWR) Command Quiesce Time (CQT) Recommended Host-Initiated Refresh Interval (RHIRI) Host-Initiated Refresh Time (HIRT) Signed-off-by: Steven Seungcheol Lee <[email protected]>
igaw
reviewed
Dec 2, 2024
| * not supported by this controller. | ||
| * 10b - RPMB Boot Partition Write Protection is | ||
| * supported by this controller. | ||
| * 11b - Reserved |
There was a problem hiding this comment.
Could you also introduce enums for these? Thanks!
|
looks good, just add the mask/shift things and also the missing bit field definition, so that all is consistent. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boot Partition Capabilities (BPCAP)
NVM Subsystem Shutdown Latency (NSSL)
Power Loss Signaling Information (PLSI)
Controller Reachability Capabilities (CRCAP)
Key Per I/O Capabilities (KPIOC)
Maximum Processing Time for Firmware Activation Without Reset (MPTFAWR)