Two small debug message improvements #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a valid use case to flash a single partition (such as CDT) with QDL. In such a case when we are not flashing the entire image, we effectively are not flashing any 'boot' partition (SBL, XBL, ...), and we don't need to send the setbootablestoragedrive command to the programmer. Currently we display the 'no boot partition found' message which is confusing for users, as it looks like an error message even though it's not. Let's turn this message into a debug log message instead. Signed-off-by: Nicolas Dechesne <[email protected]>
On some platforms, we support Boot LUN redundancy, with the boot partitions duplicated on more than 1 LUN. Only 1 LUN can be boot active at any time, but the platform can switch on reboot in case of corruption. As such, when flashing a full system, we end up flashing boot partition on several LUN, and the "first" LUN with SBL or XBL will be used as the initial/primary boot device for the setbootablestoragedrive command. Up until this commit we displayed an error message in this situation, but let's turn that into an ux_info() log instead, since it's not an error. Signed-off-by: Nicolas Dechesne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.