Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sparse image support (no deps on libsparse) #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bmx666
Copy link

@bmx666 bmx666 commented Feb 17, 2023

Hi @andersson, yep, it is another "sparse" version but without deps on libsparse. I've been testing it on several QCOM projects for over 2 years now, no problem.

@parport0
Copy link

parport0 commented Mar 4, 2023

@bmx666 Hi,

Why is this PR a draft? Are there any flaws in this implementation?

@bmx666
Copy link
Author

bmx666 commented Mar 5, 2023

Hi @parport0

Why is this PR a draft?

I'm waiting feedback from maintainer...

Are there any flaws in this implementation?

There are only two flaws:

  • upload speed can drop significantly if the image contains a lot of small chunks, compared to QPST / QFIL. Some kind of optimization is needed to merge and send many small fragments at once, because image may contain several small fragments following each other.
  • CHUNK_TYPE_FILL is not yet supported, but it can be easily implemented.

@bmx666 bmx666 closed this Jun 14, 2024
@bmx666 bmx666 deleted the sparse branch June 14, 2024 10:17
@bmx666 bmx666 restored the sparse branch June 14, 2024 10:17
@bmx666 bmx666 reopened this Jun 15, 2024
@obbardc
Copy link
Contributor

obbardc commented Oct 17, 2024

Looks pretty good to me, thanks @bmx666
Slowdown is fine, I guess. But perhaps CHUNK_TYPE_FILL is more important ?

@bmx666
Copy link
Author

bmx666 commented Oct 17, 2024

Looks pretty good to me, thanks @bmx666 Slowdown is fine, I guess. But perhaps CHUNK_TYPE_FILL is more important ?

Hi @obbardc , I uploaded an update to support CHUNK_TYPE_FILL a long time ago. Also during my research on Qualcomm tools, they replace the 4-byte chunks of fill values with one big CHUNK_TYPE_RAW.
Anyway, I don't have access to any Qualcomm boards anymore, I couldn't confirm and verify this patch.

@bmx666 bmx666 marked this pull request as ready for review October 17, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants