Assignment setup for 2-uart #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavip
pushed a commit
to linux-kernel-labs/linux-kernel-labs.github.io
that referenced
this pull request
Mar 28, 2018
tavip
approved these changes
Mar 28, 2018
alexandrasandulescu
force-pushed
the
2-uart
branch
from
80559d4 to
589229a
Compare
tools: assignments: 2-uart: Apply checkpatch.pl Signed-off-by: Alexandra Sandulescu <[email protected]>
tavip
pushed a commit
to linux-kernel-labs/linux-kernel-labs.github.io
that referenced
this pull request
Mar 29, 2018
alexandrasandulescu
force-pushed
the
2-uart
branch
from
589229a to
6dd0af0
Compare
tavip
pushed a commit
to linux-kernel-labs/linux-kernel-labs.github.io
that referenced
this pull request
Mar 29, 2018
dbaluta
reviewed
Mar 29, 2018
| @@ -0,0 +1,14 @@ | |||
| CFLAGS = -Wall -g -static -m32 | |||
|
|
|||
There was a problem hiding this comment.
Please add a more detailed commit message. "Refactoring" is too generic.
Something like: tools: assignments: 2-uart: Adapt the code to new file structure
Also, one commit should do only one thing!
Your commit does two: One is moving Makefile into Makefile.checker the other one is renaming solutie to link_handler.
I'm not even sure that link_handler is correct. As far as I remember solutie.ko is used to test if the submitted homework correctly checks for errors. So, I would rename it to dummy_uart.ko
Signed-off-by: Alexandra Sandulescu <[email protected]>
Signed-off-by: Alexandra Sandulescu <[email protected]>
alexandrasandulescu
force-pushed
the
2-uart
branch
from
6dd0af0 to
acb165f
Compare
tavip
pushed a commit
to linux-kernel-labs/linux-kernel-labs.github.io
that referenced
this pull request
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.