Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: teaching: address-space: Fix incorrect label in linux paging figure #408

Closed
wants to merge 1 commit into from
Closed

Conversation

RoundRaccoon
Copy link

In the address space lecture, at the linux paging figure, there is a typo where the second "PAGE GLOBAL DIRECTORY" should be "PAGE TABLE".

@@ -492,8 +492,8 @@ address.
| | | | | | /----------------------\
| | | | | | | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit doesn't seem to have the subject as we discussed:

Documentation: teaching: address-space: Fix incorrect label in linux paging figure

you only added the correct subject to github PR, but that will be lost once we merge the patch.

We want to actual commit to have the message.

You can just do:

$ git commit --amend
# fix the commit
$ git push -f  # this will update the existing PR (no need to create a new one).

@dbaluta
Copy link
Member

dbaluta commented May 14, 2024

@RoundRaccoon we also need your Signed-off-by line in the commit message. Check git log to see other commits.

e.g Signed-off-by: FirstName LastName <email>

@RoundRaccoon RoundRaccoon closed this by deleting the head repository Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants