module: update state and release reference under lock

Ensure the module state change and reference drop operations are performed within module_mutex to prevent potential race conditions in the failure path. Signed-off-by: Daniel Gomez <[email protected]>
linux-kdevops · Nov 26, 2024 · 08452ad · 08452ad
1 parent 84e5ed0
commit 08452ad
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/kernel/module/main.c b/kernel/module/main.c
@@ -2902,10 +2902,12 @@ static noinline int do_init_module(struct module *mod)
 fail_free_freeinit:
 	kfree(freeinit);
 fail:
+	mutex_lock(&module_mutex);
 	/* Try to protect us from buggy refcounters. */
 	mod->state = MODULE_STATE_GOING;
-	synchronize_rcu();
 	module_put(mod);
+	mutex_unlock(&module_mutex);
+	synchronize_rcu();
 	blocking_notifier_call_chain(&module_notify_list,
 				     MODULE_STATE_GOING, mod);
 	klp_module_going(mod);