feat: add relative option to let lint-staged work with ng lint #534

bnjjj · 2018-11-06T14:55:18Z

In order to work with the new version of angular-cli which is now using --files parameter to pass specific RELATIVE file paths to lint (see here) I wasn't able to let my project working with lint-staged. I think I'm not the only one in this situation.

Signed-off-by: Benjamin Coenen [email protected]

Signed-off-by: Benjamin Coenen <[email protected]>

codecov · 2018-11-06T15:06:50Z

Codecov Report

Merging #534 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage      98%   98.02%   +0.01%     
==========================================
  Files          13       13              
  Lines         351      354       +3     
  Branches       44       45       +1     
==========================================
+ Hits          344      347       +3     
  Misses          7        7

Impacted Files	Coverage Δ
src/getConfig.js	`100% <ø> (ø)`	⬆️
src/generateTasks.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e607ef...f63b8e2. Read the comment docs.

okonet · 2018-11-07T22:09:03Z

I’m wondering if this should be the default behavior. Not sure why we went with absolute paths tbh. I’ll think about it...

bnjjj · 2018-11-08T10:32:55Z

@okonet why not but it will be a breaking change if it's the default behavior

okonet · 2018-11-08T13:46:27Z

Yeah that's okay. My main question is why we even work with absolute paths. Anyone? @sudo-suhas @luftywiranda13?

buszu · 2018-11-16T13:16:31Z

Great work! Thanks to using relative paths I can run a linter from docker.

okonet · 2018-11-16T13:50:15Z

Okay some there is no reply from other contributors, let’s make this a default behavior and release as a breaking change. I am not a fan of flags and would like to drop advanced config at some time point. Can you please update the PR accordingly and I’ll merge it. Thanks!

bnjjj · 2018-11-16T15:29:26Z

@okonet Ok so no option to let user keep the absolute path ?

okonet · 2018-11-16T17:53:01Z

I don’t see the point of having it. Am I missing some use cases?

bnjjj · 2018-11-20T16:17:29Z

@okonet the PR is ready :)

okonet

Please check if we’re not breaking the case that lead to introduction of absolute paths.

README.md

okonet · 2018-11-20T18:02:04Z

test/generateTasks.spec.js

    })

    const parentFolderTask = result.find(item => item.pattern === '../outside/*.js')
    expect(parentFolderTask).toEqual({
      pattern: '../outside/*.js',
      commands: 'my-cmd',
-      fileList: [`${workDir}/outside/test.js`, `${workDir}/outside/test2.js`].map(path.normalize)
+      fileList: [`../outside/test.js`, `../outside/test2.js`].map(path.normalize)


I found why absolute paths were introduced. Here is the commit: bnjjj@41ae0cb

Can you please ensure we don’t break this use case? We should add a test if it doesn’t exist.

Ok, I'm a little bit lost... Here in the readme documentation I saw that you indicate a pattern relative to your package.json and so return an absolute path. I think it's a little bit weird to pass a pattern which is relative to package.json but after we return a relative path to the git root directory. BTW if you check your note NOTE: If you're using lint-staged<5 globs have to be relative to the git root. so if I return relative path to the git root it will be the behavior of previous version. So what is your request exactly ?

Pass pattern relative to package.json and returns path relative to the git root
OR

Pass pattern relative to your git root and returns path relative to the git root
OR

Pass pattern relative to your package.json and return path relative to the package.json

BTW your linked commit seems deprecated since gitDir option doesn't exist anymore.

I'm sorry for the confusion. I believe the case we're talking about is then the git root and package.json location aren't the same. Imagine following scenario:

.git/ subdir/ |-package.json |-node_modules

in this case, linters will be installed into subir/node_modules and passing paths relative to .git/ to them is not going to work, since they are going to be executed relative to subdir/. That's why I believe we have introduced absolute paths in the first place. The more I think about it, the more I tend to keep it like this since I don't know how to remove the ambiguity with this scenario.

Do you have any ideas? If not, I'm sorry for the extra work but I think then we need to revert to
d770672 and add it as an option. Thoughts?

IMHO it would be better to keep relative as an option, because it could create some side effects to put all path to relative. Currently on my project I work with a subdirectory like:

.git/ ui/ |-package.json |-node_modules

and now at this time it return the path relative to my package.json but when I see the PR and issue you're linked before I think it's not really the same case as me. So if you want I can rollback to d770672

Let me know :)

Okay, let's revert then if you think it's better. I'd like to keep config as minimal as possible but at the same time it would be bad to break some edge cases.

What I'm wondering about is if relative will work for your case. And if yes, why?

thanks to this line https://github.com/okonet/lint-staged/blob/master/src/generateTasks.js#L33 and yes it works for my case because my linter is located in ui/node_modules and all my files need to be linted are in ui/

okonet · 2018-11-20T18:02:25Z

test/getConfig.spec.js

@@ -141,7 +141,8 @@ describe('getConfig', () => {
      },
      ignore: ['docs/**/*.js'],
      subTaskConcurrency: 10,
-      renderer: 'custom'
+      renderer: 'custom',
+      relative: true


Is the option still needed?

nope, you're right

bnjjj · 2018-11-21T10:05:20Z

PR updated :)

okonet · 2018-11-21T14:15:41Z

Thanks!

757: chore(deps): update dependency lint-staged to v8.1.0 r=dicarlo2 a=renovate[bot] This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | lint-staged | devDependencies | minor | `8.0.5` -> `8.1.0` | [source](https://renovatebot.com/gh/okonet/lint-staged) | --- ### Release Notes <details> <summary>okonet/lint-staged</summary> ### [`v8.1.0`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.1.0) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.5...v8.1.0) ### [8.1.0](http://git+https/github.com/okonet/lint-staged/compare/v8.0.5...v8.1.0) (2018-11-21) ##### Features - Add `relative` option to allow passing relative paths to linters ([#534](http://git+https/github.com/lint-staged/lint-staged/issues/534)) ([fcb774b](http://git+https/github.com/okonet/lint-staged/commit/fcb774b)) </details> --- ### Renovate configuration :date: **Schedule**: "after 10pm every weekday,before 5am every weekday,every weekend" (UTC). :vertical_traffic_light: **Automerge**: Enabled. :recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#neo-one-suite/neo-one). Co-authored-by: Renovate Bot <[email protected]>

This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | lint-staged | devDependencies | minor | `8.0.5` -> `8.1.0` | [source](https://renovatebot.com/gh/okonet/lint-staged) | --- ### Release Notes <details> <summary>okonet/lint-staged</summary> ### [`v8.1.0`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.1.0) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.5...v8.1.0) ### [8.1.0](http://git+https/github.com/okonet/lint-staged/compare/v8.0.5...v8.1.0) (2018-11-21) ##### Features - Add `relative` option to allow passing relative paths to linters ([#534](http://git+https/github.com/lint-staged/lint-staged/issues/534)) ([fcb774b](http://git+https/github.com/okonet/lint-staged/commit/fcb774b)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#DIYgod/RSSHub).

This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | lint-staged | devDependencies | major | `7.3.0` -> `8.1.0` | [source](https://renovatebot.com/gh/okonet/lint-staged) | --- ### Release Notes <details> <summary>okonet/lint-staged</summary> ### [`v8.1.0`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.1.0) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.5...v8.1.0) ### [8.1.0](http://git+https/github.com/okonet/lint-staged/compare/v8.0.5...v8.1.0) (2018-11-21) ##### Features - Add `relative` option to allow passing relative paths to linters ([#534](http://git+https/github.com/lint-staged/lint-staged/issues/534)) ([fcb774b](http://git+https/github.com/okonet/lint-staged/commit/fcb774b)) ### [`v8.0.5`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.5) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.4...v8.0.5) #### [8.0.5](http://git+https/github.com/okonet/lint-staged/compare/v8.0.4...v8.0.5) (2018-11-17) ##### Bug Fixes - Use listr-update-renderer from npm ([#542](http://git+https/github.com/lint-staged/lint-staged/issues/542)) ([503110d](http://git+https/github.com/okonet/lint-staged/commit/503110d)), closes [#533](http://git+https/github.com/lint-staged/lint-staged/issues/533) ### [`v8.0.4`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.4) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.3...v8.0.4) #### [8.0.4](http://git+https/github.com/okonet/lint-staged/compare/v8.0.3...v8.0.4) (2018-10-31) ##### Bug Fixes - **package:** update staged-git-files to version 1.1.2 ([ce434d3](http://git+https/github.com/okonet/lint-staged/commit/ce434d3)) ### [`v8.0.3`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.3) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.2...v8.0.3) #### [8.0.3](http://git+https/github.com/okonet/lint-staged/compare/v8.0.2...v8.0.3) (2018-10-30) ##### Bug Fixes - Allow to use lint-staged on CI ([#523](http://git+https/github.com/lint-staged/lint-staged/issues/523)) ([225a904](http://git+https/github.com/okonet/lint-staged/commit/225a904)) ### [`v8.0.2`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.2) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.1...v8.0.2) #### [8.0.2](http://git+https/github.com/okonet/lint-staged/compare/v8.0.1...v8.0.2) (2018-10-29) ##### Bug Fixes - **git:** Use resolveGitDir in hasPartiallyStagedFiles ([#520](http://git+https/github.com/lint-staged/lint-staged/issues/520)) ([af99172](http://git+https/github.com/okonet/lint-staged/commit/af99172)), closes [#514](http://git+https/github.com/lint-staged/lint-staged/issues/514) ### [`v8.0.1`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.1) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.0...v8.0.1) #### [8.0.1](http://git+https/github.com/okonet/lint-staged/compare/v8.0.0...v8.0.1) (2018-10-29) ##### Bug Fixes - **git:** Use resolveGitDir to resolve to .git for git commands ([#518](http://git+https/github.com/lint-staged/lint-staged/issues/518)) ([da42f8a](http://git+https/github.com/okonet/lint-staged/commit/da42f8a)), closes [#514](http://git+https/github.com/lint-staged/lint-staged/issues/514) ### [`v8.0.0`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.0) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v7.3.0...v8.0.0) ### [8.0.0](http://git+https/github.com/okonet/lint-staged/compare/v7.3.0...v8.0.0) (2018-10-29) ##### Features - Add support for partially staged files ([#75](http://git+https/github.com/lint-staged/lint-staged/issues/75)) ([f82443c](http://git+https/github.com/okonet/lint-staged/commit/f82443c)), closes [#62](http://git+https/github.com/lint-staged/lint-staged/issues/62) ##### BREAKING CHANGES - Node >= 8.6 is required </details> --- ### Renovate configuration :date: **Schedule**: "after 6pm every weekday,before 5am every weekday" in timezone America/Los_Angeles. :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#apollographql/apollo-server).

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 8.0.5 to 8.1.0. <details> <summary>Release notes</summary> *Sourced from [lint-staged's releases](https://github.com/okonet/lint-staged/releases).* > ## v8.1.0 > # [8.1.0](http://git+https/github.com/okonet/lint-staged/compare/v8.0.5...v8.1.0) (2018-11-21) > > > ### Features > > * Add `relative` option to allow passing relative paths to linters ([#534](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/534)) ([fcb774b](http://git+https/github.com/okonet/lint-staged/commit/fcb774b)) </details> <details> <summary>Commits</summary> - [`fcb774b`](lint-staged/lint-staged@fcb774b) feat: Add `relative` option to allow passing relative paths to linters ([#534](https://github-redirect.dependabot.com/okonet/lint-staged/issues/534)) - [`5e607ef`](lint-staged/lint-staged@5e607ef) docs: Fix typo in README.md ([#537](https://github-redirect.dependabot.com/okonet/lint-staged/issues/537)) - [`8285123`](lint-staged/lint-staged@8285123) chore: Upgrade husky to v1 ([#543](https://github-redirect.dependabot.com/okonet/lint-staged/issues/543)) - [`48c5b65`](lint-staged/lint-staged@48c5b65) chore: pin cosmiconfig to 5.0.6 ([#538](https://github-redirect.dependabot.com/okonet/lint-staged/issues/538)) - See full diff in [compare view](lint-staged/lint-staged@v8.0.5...v8.1.0) </details> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=lint-staged&package-manager=npm_and_yarn&previous-version=8.0.5&new-version=8.1.0)](https://dependabot.com/compatibility-score.html?dependency-name=lint-staged&package-manager=npm_and_yarn&previous-version=8.0.5&new-version=8.1.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. If all status checks pass Dependabot will automatically merge this pull request. --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 8.0.5 to 8.1.0. <details> <summary>Release notes</summary> *Sourced from [lint-staged's releases](https://github.com/okonet/lint-staged/releases).* > ## v8.1.0 > # [8.1.0](http://git+https/github.com/okonet/lint-staged/compare/v8.0.5...v8.1.0) (2018-11-21) > > > ### Features > > * Add `relative` option to allow passing relative paths to linters ([#534](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/534)) ([fcb774b](http://git+https/github.com/okonet/lint-staged/commit/fcb774b)) </details> <details> <summary>Commits</summary> - [`fcb774b`](lint-staged/lint-staged@fcb774b) feat: Add `relative` option to allow passing relative paths to linters ([#534](https://github-redirect.dependabot.com/okonet/lint-staged/issues/534)) - [`5e607ef`](lint-staged/lint-staged@5e607ef) docs: Fix typo in README.md ([#537](https://github-redirect.dependabot.com/okonet/lint-staged/issues/537)) - [`8285123`](lint-staged/lint-staged@8285123) chore: Upgrade husky to v1 ([#543](https://github-redirect.dependabot.com/okonet/lint-staged/issues/543)) - [`48c5b65`](lint-staged/lint-staged@48c5b65) chore: pin cosmiconfig to 5.0.6 ([#538](https://github-redirect.dependabot.com/okonet/lint-staged/issues/538)) - See full diff in [compare view](lint-staged/lint-staged@v8.0.5...v8.1.0) </details> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=lint-staged&package-manager=npm_and_yarn&previous-version=8.0.5&new-version=8.1.0)](https://dependabot.com/compatibility-score.html?dependency-name=lint-staged&package-manager=npm_and_yarn&previous-version=8.0.5&new-version=8.1.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>

michaeljota · 2018-11-28T20:25:53Z

@bnjjj This doesn't work for my as the files are being recognized as Unknown option. :/

bnjjj · 2018-11-29T08:22:51Z

@michaeljota Yes my bad I tested with only one diff file, so it worked. But relative path is a first iteration to let ng lint work with lint-staged. We need to resolve your issue to fix the issue for multiple diff files

This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | lint-staged | devDependencies | major | `7.3.0` -> `8.1.0` | [source](https://renovatebot.com/gh/okonet/lint-staged) | --- ### Release Notes <details> <summary>okonet/lint-staged</summary> ### [`v8.1.0`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.1.0) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.5...v8.1.0) ### [8.1.0](http://git+https/github.com/okonet/lint-staged/compare/v8.0.5...v8.1.0) (2018-11-21) ##### Features - Add `relative` option to allow passing relative paths to linters ([#534](http://git+https/github.com/lint-staged/lint-staged/issues/534)) ([fcb774b](http://git+https/github.com/okonet/lint-staged/commit/fcb774b)) ### [`v8.0.5`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.5) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.4...v8.0.5) #### [8.0.5](http://git+https/github.com/okonet/lint-staged/compare/v8.0.4...v8.0.5) (2018-11-17) ##### Bug Fixes - Use listr-update-renderer from npm ([#542](http://git+https/github.com/lint-staged/lint-staged/issues/542)) ([503110d](http://git+https/github.com/okonet/lint-staged/commit/503110d)), closes [#533](http://git+https/github.com/lint-staged/lint-staged/issues/533) ### [`v8.0.4`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.4) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.3...v8.0.4) #### [8.0.4](http://git+https/github.com/okonet/lint-staged/compare/v8.0.3...v8.0.4) (2018-10-31) ##### Bug Fixes - **package:** update staged-git-files to version 1.1.2 ([ce434d3](http://git+https/github.com/okonet/lint-staged/commit/ce434d3)) ### [`v8.0.3`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.3) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.2...v8.0.3) #### [8.0.3](http://git+https/github.com/okonet/lint-staged/compare/v8.0.2...v8.0.3) (2018-10-30) ##### Bug Fixes - Allow to use lint-staged on CI ([#523](http://git+https/github.com/lint-staged/lint-staged/issues/523)) ([225a904](http://git+https/github.com/okonet/lint-staged/commit/225a904)) ### [`v8.0.2`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.2) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.1...v8.0.2) #### [8.0.2](http://git+https/github.com/okonet/lint-staged/compare/v8.0.1...v8.0.2) (2018-10-29) ##### Bug Fixes - **git:** Use resolveGitDir in hasPartiallyStagedFiles ([#520](http://git+https/github.com/lint-staged/lint-staged/issues/520)) ([af99172](http://git+https/github.com/okonet/lint-staged/commit/af99172)), closes [#514](http://git+https/github.com/lint-staged/lint-staged/issues/514) ### [`v8.0.1`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.1) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v8.0.0...v8.0.1) #### [8.0.1](http://git+https/github.com/okonet/lint-staged/compare/v8.0.0...v8.0.1) (2018-10-29) ##### Bug Fixes - **git:** Use resolveGitDir to resolve to .git for git commands ([#518](http://git+https/github.com/lint-staged/lint-staged/issues/518)) ([da42f8a](http://git+https/github.com/okonet/lint-staged/commit/da42f8a)), closes [#514](http://git+https/github.com/lint-staged/lint-staged/issues/514) ### [`v8.0.0`](https://renovatebot.com/gh/okonet/lint-staged/releases/v8.0.0) [Compare Source](https://renovatebot.com/gh/okonet/lint-staged/compare/v7.3.0...v8.0.0) ### [8.0.0](http://git+https/github.com/okonet/lint-staged/compare/v7.3.0...v8.0.0) (2018-10-29) ##### Features - Add support for partially staged files ([#75](http://git+https/github.com/lint-staged/lint-staged/issues/75)) ([f82443c](http://git+https/github.com/okonet/lint-staged/commit/f82443c)), closes [#62](http://git+https/github.com/lint-staged/lint-staged/issues/62) ##### BREAKING CHANGES - Node >= 8.6 is required </details> --- ### Renovate configuration :date: **Schedule**: "after 6pm every weekday,before 5am every weekday" in timezone America/Los_Angeles. :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#apollographql/apollo-tooling).

…o linters (#534)" This reverts commit fcb774b.

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 8.0.5 to 8.1.0. <details> <summary>Release notes</summary> *Sourced from [lint-staged's releases](https://github.com/okonet/lint-staged/releases).* > ## v8.1.0 > # [8.1.0](http://git+https/github.com/okonet/lint-staged/compare/v8.0.5...v8.1.0) (2018-11-21) > > > ### Features > > * Add `relative` option to allow passing relative paths to linters ([#534](http://git+https/github-redirect.dependabot.com/lint-staged/lint-staged/issues/534)) ([fcb774b](http://git+https/github.com/okonet/lint-staged/commit/fcb774b)) </details> <details> <summary>Commits</summary> - [`fcb774b`](lint-staged/lint-staged@fcb774b) feat: Add `relative` option to allow passing relative paths to linters ([#534](https://github-redirect.dependabot.com/okonet/lint-staged/issues/534)) - [`5e607ef`](lint-staged/lint-staged@5e607ef) docs: Fix typo in README.md ([#537](https://github-redirect.dependabot.com/okonet/lint-staged/issues/537)) - [`8285123`](lint-staged/lint-staged@8285123) chore: Upgrade husky to v1 ([#543](https://github-redirect.dependabot.com/okonet/lint-staged/issues/543)) - [`48c5b65`](lint-staged/lint-staged@48c5b65) chore: pin cosmiconfig to 5.0.6 ([#538](https://github-redirect.dependabot.com/okonet/lint-staged/issues/538)) - See full diff in [compare view](lint-staged/lint-staged@v8.0.5...v8.1.0) </details> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=lint-staged&package-manager=npm_and_yarn&previous-version=8.0.5&new-version=8.1.0)](https://dependabot.com/compatibility-score.html?dependency-name=lint-staged&package-manager=npm_and_yarn&previous-version=8.0.5&new-version=8.1.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>

feat: add relative option to let lint-staged work with ng lint

04fe88e

Signed-off-by: Benjamin Coenen <[email protected]>

bnjjj force-pushed the master branch from 41e9ae8 to 04fe88e Compare November 6, 2018 15:06

buszu mentioned this pull request Nov 16, 2018

add option to use relative paths in commands #369

Closed

okonet requested changes Nov 20, 2018

View reviewed changes

bnjjj force-pushed the master branch from 8adcf77 to 04fe88e Compare November 21, 2018 10:04

Merge branch 'master' into master

f63b8e2

okonet approved these changes Nov 21, 2018

View reviewed changes

okonet merged commit fcb774b into lint-staged:master Nov 21, 2018

okonet mentioned this pull request Nov 23, 2018

Doesn't work in angular/cli 7 project #547

Closed

michaeljota mentioned this pull request Nov 28, 2018

Arguments after files option should be considered files. angular/angular-cli#13078

Closed

okonet mentioned this pull request Dec 19, 2018

Allow defining a template for how paths should be passed to the command #138

Closed

okonet added a commit that referenced this pull request Jan 18, 2019

Revert "feat: Add relative option to allow passing relative paths t…

0b16bf1

…o linters (#534)" This reverts commit fcb774b.

AndreiShostik mentioned this pull request Sep 26, 2019

docs: fix example with relative paths (#547) #705

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add relative option to let lint-staged work with ng lint #534

feat: add relative option to let lint-staged work with ng lint #534

bnjjj commented Nov 6, 2018

codecov bot commented Nov 6, 2018 •

edited

Loading

okonet commented Nov 7, 2018

bnjjj commented Nov 8, 2018

okonet commented Nov 8, 2018

buszu commented Nov 16, 2018

okonet commented Nov 16, 2018

bnjjj commented Nov 16, 2018

okonet commented Nov 16, 2018

bnjjj commented Nov 20, 2018

okonet left a comment

okonet Nov 20, 2018

bnjjj Nov 21, 2018

okonet Nov 21, 2018

bnjjj Nov 21, 2018

okonet Nov 21, 2018

bnjjj Nov 21, 2018

okonet Nov 20, 2018

bnjjj Nov 21, 2018

bnjjj commented Nov 21, 2018

okonet commented Nov 21, 2018

michaeljota commented Nov 28, 2018

bnjjj commented Nov 29, 2018

feat: add relative option to let lint-staged work with ng lint #534

feat: add relative option to let lint-staged work with ng lint #534

Conversation

bnjjj commented Nov 6, 2018

codecov bot commented Nov 6, 2018 • edited Loading

Codecov Report

okonet commented Nov 7, 2018

bnjjj commented Nov 8, 2018

okonet commented Nov 8, 2018

buszu commented Nov 16, 2018

okonet commented Nov 16, 2018

bnjjj commented Nov 16, 2018

okonet commented Nov 16, 2018

bnjjj commented Nov 20, 2018

okonet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bnjjj commented Nov 21, 2018

okonet commented Nov 21, 2018

michaeljota commented Nov 28, 2018

bnjjj commented Nov 29, 2018

codecov bot commented Nov 6, 2018 •

edited

Loading