Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-9404] - 4.0.0 Design Tokens - New Spacing & Badge Tokens #11757

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jaalah-akamai
Copy link
Contributor

Description 📝

We've renamed and improved our spacing tokens to eliminate confusion. The new naming convention now uses pixel values (like "s8" which corresponds to 8px instead of abstract numbers), which aligns with how UX designers work in Figma. While designers can now reference these more intuitive pixel-based names / values, our code still uses REM units behind the scenes for proper scaling and accessibility. This change creates a better workflow between design and development teams, as both can refer to the same token names despite working in different unit systems.

Changes 🔄

Badge [BREAKING]

  • New badge group type accent introduced
  • Moved old badge styles under the subtle group

Spacing Tokens [BREAKING]
Pixel values are transformed to REM in code

Old → New
0 → S0 (0px)
10 → S2 (2px)
20 → S4 (4px)
30 → S6 (6px)
40 → S8 (8px)
50 → S12 (12px)
60 → S16 (16px)
70 → S24 (24px)
80 → S32 (32px)
90 → S48 (48px)

Added new spacing tokens:
S20 (20px)
S28 (28px)
S36 (36px)
S40 (40px)
S64 (64px)
S72 (72px)
S96 (96px)

You can use these in cloud manager like so

Old → New
theme.tokens.spacing[50] → theme.tokens.spacing.S12

Target release date 🗓️

3/11

Preview 📷

Screenshot 2025-02-24 at 4 19 09 PM

How to test 🧪

Verification steps

  • pnpm install && pnpm dev
  • Ensure there's no linting, typescript or other build errors
  • Ensure no visual regression from previous
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jaalah-akamai jaalah-akamai requested a review from a team as a code owner February 27, 2025 19:09
@jaalah-akamai jaalah-akamai requested review from hana-akamai and carrillo-erik and removed request for a team February 27, 2025 19:09
@jaalah-akamai jaalah-akamai self-assigned this Feb 27, 2025
@jaalah-akamai jaalah-akamai added Design Tokens Laying the groundwork for Design Tokens Ready for Review labels Feb 27, 2025
Copy link

github-actions bot commented Feb 27, 2025

Coverage Report:
Base Coverage: 80.17%
Current Coverage: 80.17%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 530 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing530 Passing3 Skipped108m 38s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Tokens Laying the groundwork for Design Tokens Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants