upcoming: [M3-9355] - Fix LKE-E provisioning placeholder when filtering by status #11745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de pool status for a newly created cluster
hana-akamai
requested review from
dmcintyr-akamai,
hkhalil-akamai,
cliu-akamai and
mjac0bs
and removed request for
a team
hana-akamai
commented
Feb 27, 2025
| </TableRow> | ||
| )} | ||
| {(count > 0 || | ||
| {rowData.length === 0 && |
There was a problem hiding this comment.
We need to check the length of the original data, not the filtered data bc the filtered data could be zero and this will incorrectly show
There was a problem hiding this comment.
Makes sense - thanks for the fix!
mjac0bs
approved these changes
Feb 27, 2025
| </TableRow> | ||
| )} | ||
| {(count > 0 || | ||
| {rowData.length === 0 && |
There was a problem hiding this comment.
Makes sense - thanks for the fix!
|
@hana-akamai Just merged the copy PR, which is going to create a small merge conflict with that placeholder text. |
|
Coverage Report: ❌ |
Cloud Manager UI test results🎉 530 passing tests on test run #3 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fix provisioning placeholder incorrectly displaying when filtering a newly created Cluster by Running/Offline status
Target release date 🗓️
3/11
Preview 📷
before.mp4
after.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
You can test via e2e or create an actual LKE-E cluster and wait ~5mins for it to start provisioning
NodeTable.tsxreplacerowData.lengthback withcounton lines 192 & 218yarn cy:debugand run thelke-update.spec.tstestfilters the node tables based on selected status filtertest should failVerification steps
(How to verify changes)
lke-update.spec.tstestfilters the node tables based on selected status filtershould passAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅