-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tech-story: [M3-9098] - Add MSW crud support for firewalls and some IP functionality for Linode Interfaces project #11586
Conversation
public_interface: number; | ||
vpc_interface: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating this - it'd been a typo in the spec, see [M3-9210] for details
Coverage Report: ✅ |
thanks @hkhalil-akamai! updated the label for that seed - it should have been IP addresses, not Firewalls. While I added the seed in this pr, I haven't completely fleshed out all IP mocking, so I'm not sure if there will be a lot of visual differences (if any) for IP address mocks/the seed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! very welcome addition
Only thing is we could use a couple more relationships:
- create a firewall and assign linode => firewall created but linode won't be assigned
- create a linode and assign firewall => both created but linode won't be assigned
lastly, (and I am not sure about this) do you also need to add firewall setting or devices to the mergedContext
in load.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @coliu-akamai!
@abailly-akamai added, thanks for catching! |
Cloud Manager UI test results🎉 488 passing tests on test run #12 ↗︎
|
Cloud Manager E2E Run #7175
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #7175
|
Run duration | 28m 54s |
Commit |
0800df8a7e: tech-story: [M3-9098] - Add MSW crud support for firewalls and some IP functiona...
|
Committer | Connie Liu |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
500
|
View all changes introduced in this branch ↗︎ |
Description 📝
Changes 🔄
Preview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅