-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DI-23105] - Listing Alerts features: Pagination, Ordering, Searching, Filtering #11577
upcoming: [DI-23105] - Listing Alerts features: Pagination, Ordering, Searching, Filtering #11577
Conversation
…Search, Filtering
This PR introduces changes related to the AlertListing functionality. While the diff exceeds 500 lines due to the scope of the changes, all the updates are interconnected and part of the same feature set , so it made more sense to raise it as a single PR. Hope this is fine and works for the review process. cc: @jaalah-akamai |
Coverage Report: ✅ |
await waitFor(() => { | ||
expect(getByText('Error in fetching the alerts')).toBeVisible(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think await waitFor(...)
is needed. There is nothing async happening in the component to require this
await waitFor(() => { | |
expect(getByText('Error in fetching the alerts')).toBeVisible(); | |
}); | |
expect(getByText('Error in fetching the alerts')).toBeVisible(); |
{formatDate(updated, { | ||
format: 'MMM dd, yyyy, h:mm a', | ||
})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should timezone be handled here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure of this comment, do we need to handle it explicitly ? Currently compared to the time we have in mocks and the time showed in the Table the timezone is being handled properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ✅
Ordering of table columns ✅
Pagination ✅
Filtering and searching ✅
Error state when alert-definitions
request fails & landing page when there are no definitions ✅
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertListing.tsx
Outdated
Show resolved
Hide resolved
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
@bnussman-akamai , can you merge the PR. |
Cloud Manager E2E
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
|
Run duration | 31m 01s |
Commit |
|
Committer | santoshp210-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
2
|
|
2
|
|
0
|
|
494
|
View all changes introduced in this branch ↗︎ |
Description 📝
Added the following features to the Alerts Listing component
Changes 🔄
AlertListTable
fromAlertListing
componentAlertListing
componentCreate Alert
button from theAlertsLanding
component toAlertListing
component as per latest UX mockupsserverHandler.ts
,constants.ts
files relevant for functionalitiesTarget release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />
tag when including recordings in table.How to test 🧪
Prerequisites
aclpAlerting
, the flag has been currently disabled. For testing enable the definitions part of theaclpAlerting
flag to be true.Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅