Explicitly store (teardown) fixtures in setupVPCWithSubnetWithInstance
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
lgarber-akamai and
vshanthe
and removed request for
a team
zliang-akamai
changed the title
setupVPCWithSubnetWithInstancesetupVPCWithSubnetWithInstance
zliang-akamai
requested review from
a team,
jriddle-linode,
ykim-akamai and
amisiorek-akamai
and removed request for
a team
lgarber-akamai
approved these changes
Nov 6, 2023
ykim-akamai
approved these changes
Nov 6, 2023
zliang-akamai
changed the title
setupVPCWithSubnetWithInstancesetupVPCWithSubnetWithInstance
zliang-akamai
deleted the
zhiwei/fix-vpc-test-explicit-fixture-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Explicitly call fixture teardown function in the VPC setup function, to avoid confusion and errors that caused by API calls after fixtures teardown were not recorded.
✔️ How to Test
make fixtures ARGS="-run TestInstance_ConfigInterface"make test SKIP_LINT=1 ARGS="-run TestInstance_ConfigInterface"make fixtures ARGS="-run TestVPC"make test SKIP_LINT=1 ARGS="-run TestVPC"