Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipv4 Field of Linode Instance Interface #408

Merged

Conversation

zliang-akamai
Copy link
Member

📝 Description

Omit any empty field during JSON marshaling in IPv4 struct.

✔️ How to Test

Run make ARGS="-run TestInstance_Config" fixtures against alpha environment

@zliang-akamai zliang-akamai requested a review from a team as a code owner October 16, 2023 22:43
@zliang-akamai zliang-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team October 16, 2023 22:43
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests pass!

@zliang-akamai zliang-akamai merged commit c889822 into linode:proj/vpc Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants