Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enable LKE App Platform #648

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

yec-akamai
Copy link
Contributor

📝 Description

Support enable LKE App Platform and get relate URLs in lke modules.

✔️ How to Test

make test-int TEST_SUITE="lke_cluster_apl" 

@yec-akamai yec-akamai added the new-feature for new features in the changelog. label Feb 13, 2025
@yec-akamai yec-akamai requested a review from a team as a code owner February 13, 2025 21:56
@yec-akamai yec-akamai requested review from jriddle-linode and ezilber-akamai and removed request for a team February 13, 2025 21:56
@@ -693,6 +700,11 @@ def _populate_results(self, cluster: LKECluster) -> None:
# because it is not returned from the cluster GET endpoint
cluster_json["control_plane"]["acl"] = safe_get_cluster_acl(cluster)

# Inject the APL URLs if APL is enabled
if cluster.apl_enabled:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The apl_enabled hasn't been released in the official python-sdk yet. Will need to install from the dev branch.

Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing locally!

@yec-akamai yec-akamai added the do-not-merge PRs that should not be merged until the commented issue is resolved label Feb 18, 2025
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge PRs that should not be merged until the commented issue is resolved new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants