Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only warn if version getter fails #47

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: only warn if version getter fails #47

merged 1 commit into from
Jan 10, 2024

Conversation

wbollock
Copy link
Collaborator

@wbollock wbollock commented Jan 9, 2024

rather than exit the program, return all errors outside function and throw warnings

@wbollock
fix: only warn if version getter fails
11708e3 
rather than exit the program, return all errors outside function and
throw warnings
stalloneclone
stalloneclone approved these changes Jan 10, 2024
View reviewed changes
Copy link

@stalloneclone stalloneclone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@wbollock wbollock merged commit ea9f0ab into main Jan 10, 2024
2 checks passed
@wbollock wbollock deleted the fix/version_update_warn branch January 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalloneclone stalloneclone stalloneclone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbollock @stalloneclone