Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part Templates ui #288

Open
lewisrenfrew opened this issue Nov 9, 2021 · 3 comments · Fixed by #293
Open

Part Templates ui #288

lewisrenfrew opened this issue Nov 9, 2021 · 3 comments · Fixed by #293
Assignees
@RossStewart

Comments

@lewisrenfrew
Copy link
Collaborator

we already have:

  • PartTemplate Domain Class

  • PartTemplateRepository (required methods might not be implemented)

  • Database mapping in ServiceDbContext

  • FacadeService (required methods might not be implemented)

  • PartTemplateResource

  • ResourceBuilders for requesting multiple PartTemplates and a Single Part Template

  • Response Processor for responding with multiple PartTemplates

  • Nancy route for requesting all PartTemplates

  • Service test for that Nancy route

  • all the redux gubbins we need to request all PartTemplates (action creators, reducer, selectors)

Need to add:

  • domain service to facilitate creating and updating a PartTemplate with permission checks + corresponding unit tests. The part.admin privilege is probably good enough for now.

  • missing response processor for responding with a single PartTemplate

  • Nancy routes to create/update PartTemplates

  • Service tests for the above

  • all the redux gubbins required to request/create/update a single PartTemplate (using the components library)

a React UI (using the components library) to:

  • view all templates
  • view/update single template
  • create a new template
  • front end tests for all the above
@richardiphillips
Copy link
Collaborator

richardiphillips commented Nov 9, 2021 •
edited
Loading

Make sure the resourcebuilder uses the user's privileges to generate edit and/or create link rels when appropriate and use these links to decide whether the editing and creating are allowed in the front end.

@RossStewart RossStewart linked a pull request Nov 12, 2021 that will close this issue
PartTemplate work #293
Merged
@RossStewart
Copy link
Contributor

@richardiphillips I just pushed some PartTemplate FacadeService tests there and used a Should().ContainAll() when I was checking the strings for the result - should I be using this method or maybe something else? Just want to make sure I'm consistent with the codebase. I saw some uses of Contains(0 so I could always change it to that or use a different method entirely, just wanted to ask and make sure.

@richardiphillips
Copy link
Collaborator

richardiphillips commented Nov 15, 2021 via email

@lewisrenfrew lewisrenfrew reopened this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RossStewart RossStewart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PartTemplate work linn/stores
3 participants
@RossStewart @richardiphillips @lewisrenfrew