Added support of custom table name #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,8 @@ def __new__(mcs, name, bases, dct): | |||
| return super_new(mcs, name, bases, dct) | |||
|
|
|||
| # Set metadata | |||
| dct['_table'] = tableize(name) | |||
| if '_table' not in dct: | |||
There was a problem hiding this comment.
I'm thinking, since specifying a table is "public" now, I would have dct['table'] rather than dct['_table']. This would lead to a more readable API as well:
class Artist(Model):
table = 'artist_tbl'
|
OK I just pushed |
|
Sorry for the long wait 👍 Since this PR introduced the need to get rid of a deprecated method, I need to take some time to properly address this issue, as well as some small others and release a major version which is not fully backwards compatible with 0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to specify table name in class definition, overwriting the default pluralized class name