chore(makefile): minor updates for make clean/setup #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noelmcloughlin
changed the title
sierra-moxon
reviewed
Feb 9, 2023
| git add $(patsubst %, project/%, $(PROJECT_FOLDERS)) | ||
| git-commit: | ||
| git commit -m 'Initial commit' -a | ||
| git commit -m 'chore: initial commit' -a |
There was a problem hiding this comment.
I'd never seen this before chore – changes that do not relate to a fix or feature and don't modify src or test files (for example updating dependencies) refactor – refactored code that neither fixes a bug nor adds a feature. :)
There was a problem hiding this comment.
See comment below thx
sierra-moxon
approved these changes
Feb 9, 2023
|
Thanks, there is devops pattern of using commitlint to have some rules, can
annoy some people but allows automation from commit messages, typically
using semantic-release for intelligent semantic versions, and auto
generating release notes. I use commit lint style as habit..
…On Thu 9 Feb 2023, 16:12 Sierra Moxon, ***@***.***> wrote:
Merged #40 <#40>
into main.
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFUUQX3SZGGVRGAZLDSJ5LWWUJPHANCNFSM6AAAAAAUKPZ7SA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is minor updates to Makefile: