Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile-sheets recipe still exists if user chooses "No" to use_schemasheets during setup. #21

Merged
merged 34 commits into from
Sep 30, 2022

Conversation

hrshdhgd
Copy link
Collaborator

As the code is set up now if a user selects 'No' for use_schemasheets during setup, the compile-sheets recipe is blank. This PR changes that and gen-project will just not have compile-sheets as a dependency.

@hrshdhgd hrshdhgd marked this pull request as ready for review September 23, 2022 21:35
@sierra-moxon
Copy link
Member

Thanks so much @hrshdhgd!! I would be fine adding this to the cookie-cutter before the workshop. But I'm also fine waiting. @turbomam - could you weigh in?

@hrshdhgd
Copy link
Collaborator Author

hrshdhgd commented Sep 23, 2022

Yeah, I had noticed this a while ago and meant to do this sooner. Sorry for the last minute update. You can test this locally by running cruft create https://github.com/hrshdhgd/linkml-project-cookiecutter if planning to merge before the workshop. After the workshop may be a safer option but upto you all.

@cmungall cmungall marked this pull request as draft September 23, 2022 21:49
@cmungall
Copy link
Member

I converted to draft while we decide but leave it up to you whether you want to bring in. May be too late on east coast for Mark though

@sierra-moxon
Copy link
Member

ok - since its Mark's section that would need to change, lets just wait.

@sierra-moxon sierra-moxon marked this pull request as ready for review September 30, 2022 22:15
@sierra-moxon sierra-moxon merged commit bf6174e into linkml:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants