-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Niri Service #54
Conversation
I think creating a separate example bar for Niri leads to code repetition and makes these examples harder to maintain How about adding a check? If running on Hyprland, display the hyprland workspaces, if running on Niri, display the Niri widgets accordingly |
I completely agree.
Sounds good. What do you think would be a sensible way to check this, test the existence of NIRI_SOCKET / HYPR_SOCKET_DIR ? |
Hmmm, or add new properties to Hyprland Service and Niri Service like I'm more inclined to the first option
EDIT: Better leave |
…or only on manual operations with the socket and not during service initialization
I'm a bit stuck on how to structure the example, in a way that minimizes code duplication. My apologies for being a bit inexperienced with OOP. |
Just make separate functions for niri (move them from the current |
…ate example for niri.
Thank you. |
Okay, looks good Is it ready for merging or you're planning to add additional functionality or fixes? |
Thank you for the fixups. |
Thanks! |
This PR adds a Niri service, including a sample config.
Based on the hyprland service.