feat: add UPower Service #10

linkfrg · 2024-10-03T15:27:51Z

Add ~~battery~~ UPower Service.
~~Completely stolen from AGS~~ (Now it's 100% Ignis implementation)
I don't have a device with a battery, so this pull request requires testing by other people.

How to install:

Set up a development environment
git checkout feat/battery.
On each new commit use git pull to receive new changes

Munseer-am · 2024-10-03T15:29:50Z

Add battery service. Completely stolen from AGS I don't have a device with a battery, so this pull request requires testing by other people.

Testing

I will help out with testing when I can!

linkfrg · 2024-10-03T15:43:15Z

this terrible code can help you with testing:

from ignis.services.battery import BatteryService

battery = BatteryService.get_default()

for prop_name in [
    "available",
    "percent",
    "charging",
    "charged",
    "icon_name",
    "time_remaining",
    "energy",
    "energy_full",
    "energy_rate",
]:
    battery.connect(
        f"notify::{prop_name.replace('_', '-')}",
        lambda x, y: print(f"{prop_name}: ", getattr(battery, prop_name)),
    )

Munseer-am · 2024-10-03T18:57:01Z

Issue: I am encountering an error when running the ignis init --debug.

ignis.exceptions.AnotherNotificationDaemonRunningError: Another notification daemon is already running: SwayNotificationCenter

linkfrg · 2024-10-03T19:12:01Z

Issue: I am encountering an error when running the ignis init --debug.

ignis.exceptions.AnotherNotificationDaemonRunningError: Another notification daemon is already running: SwayNotificationCenter

This is not an issue, this exception means that you have another notification daemon running. In your case it is swaync, kill or remove it

Please read the error text carefully

Munseer-am · 2024-10-03T20:16:38Z

from ignis.services.battery import BatteryService

battery = BatteryService.get_default()

print(battery.available)

it is returning False

linkfrg · 2024-10-03T20:21:06Z

try now (after 87ea7d9)

CGod-dev · 2024-10-03T20:35:10Z

I don't have a device with a battery, so this pull request requires testing by other people.

sudo udevadm trigger --subsystem-match=power_supply --action=add

linkfrg · 2024-10-03T20:41:46Z

sudo udevadm trigger --subsystem-match=power_supply --action=add

nothing changed

Munseer-am · 2024-10-03T20:49:56Z

try now (after 87ea7d9)

it is still returning False and it has a new error

battery = BatteryService.get_default()
Error while fetching Present property: 'DBusProxy' object has no attribute 'Present'
None

CGod-dev · 2024-10-03T20:53:18Z

sudo udevadm trigger --subsystem-match=power_supply --action=add

nothing changed

You can "simulate" a battery by using symlink

mkdir BAT0
sudo ln -s BAT0/ /sys/class/power_supply/BAT0/
echo 100 | sudo tee BAT0/capacity
echo "Charging" | sudo tee BAT0/status
echo 4200000 | sudo tee BAT0/voltage_now
echo 5000000 | sudo tee BAT0/current_now

Although, this method is ancient. I don't know if it will work on modern linux

linkfrg · 2024-10-04T15:43:47Z

try now (after 87ea7d9)

it is still returning False and it has a new error
battery = BatteryService.get_default()
Error while fetching Present property: 'DBusProxy' object has no attribute 'Present'
None

Have you installed upower?

CGod-dev · 2024-10-04T15:47:01Z

Being able to set a charge limit from the quick settings would be nice too, somewhat like this gnome extension

linkfrg · 2024-10-04T15:59:50Z

sudo udevadm trigger --subsystem-match=power_supply --action=add
nothing changed
You can "simulate" a battery by using symlink
mkdir BAT0
sudo ln -s BAT0/ /sys/class/power_supply/BAT0/
echo 100 | sudo tee BAT0/capacity
echo "Charging" | sudo tee BAT0/status
echo 4200000 | sudo tee BAT0/voltage_now
echo 5000000 | sudo tee BAT0/current_now
Although, this method is ancient. I don't know if it will work on modern linux

It seems that /sys cannot be modified. But I found some kernel module and it's working

CGod-dev · 2024-10-04T16:04:43Z

this terrible code can help you with testing:

from ignis.services.battery import BatteryService

battery = BatteryService.get_default()

for prop_name in [
    "available",
    "percent",
    "charging",
    "charged",
    "icon_name",
    "time_remaining",
    "energy",
    "energy_full",
    "energy_rate",
]:
    battery.connect(
        f"notify::{prop_name.replace('_', '-')}",
        lambda x, y: print(f"{prop_name}: ", getattr(battery, prop_name)),
    )

Finally got the pull request working. Here's the output (Battery is at 98 and AC is plugged in)

2024-10-04 19:03:15 [INFO] Using configuration file: /home/matt/.config/ignis/config.py
2024-10-04 19:03:15 [INFO] Applied css: /home/matt/.config/ignis/style.scss
2024-10-04 19:03:15 [INFO] Ready.
energy_rate:  0.0

…ery service

linkfrg · 2024-10-04T16:17:28Z

D-Bus proxy could not update properties because it was looking for the name in the current session bus, not in the system one. Should be fixed after 4f09d4a

Edit: strange but available is still False
Edit 2: This is because self._available never set to True in self.__sync d426567

dylanc24 · 2024-10-04T16:54:04Z

If I was smarter, I would test before It get push... But here I am, too stupid to uninstall and rebuild the package, hoping it come soon. .

CGod-dev · 2024-10-04T16:59:59Z

D-Bus proxy could not update properties because it was looking for the name in the current session bus, not in the system one. Should be fixed after 4f09d4a

Edit: strange but available is still False Edit 2: This is because self._available never set to True in self.__sync d426567

nergy_rate:  7.404
energy_rate:  7.404
energy_rate:  7.404
energy_rate:  7.404
energy_rate:  7.404
energy_rate:  7.404
energy_rate:  10.605
energy_rate:  10.605
energy_rate:  10.605
energy_rate:  10.605
energy_rate:  10.605
energy_rate:  10.605
energy_rate:  10.605
energy_rate:  10.605
energy_rate:  10.605

Looks to be working now. Can you provide instructions for fast rebuilding and installing? I am not very familiar with meson or python

linkfrg · 2024-10-04T17:00:05Z

If I was smarter, I would test before It get push... But here I am, too stupid to uninstall and rebuild the package, hoping it come soon. .

You can Set up a development environment and when:
git checkout feat/battery. On each new commit use git pull to receive new changes

linkfrg · 2024-10-04T17:02:31Z

Can you provide instructions for fast rebuilding and installing? I am not very familiar with meson or python

Added instruction in the first message

CGod-dev · 2024-10-04T17:14:06Z

Can you provide instructions for fast rebuilding and installing? I am not very familiar with meson or python

Added instruction in the first message

I know how to use git. Just can't get meson to see the changes

meson compile -C build

INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /sbin/ninja -C /redacted/for/privacy/ignis/build
ninja: Entering directory `/redacted/for/privacy/ignis/build'
ninja: no work to do.

linkfrg · 2024-10-04T17:21:36Z

Can you provide instructions for fast rebuilding and installing? I am not very familiar with meson or python

Added instruction in the first message

I know how to use git. Just can't get meson to see the changes
meson compile -C build
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /sbin/ninja -C /redacted/for/privacy/ignis/build
ninja: Entering directory `/redacted/for/privacy/ignis/build'
ninja: no work to do.

You don't need to rebuild Ignis every time. You need to do this in the first time to build submodules and install bin file. Since we are making a symbolic link in the above tutorial, we don't need to reinstall Ignis every time to update it in venv.

linkfrg · 2024-10-04T18:09:30Z

Being able to set a charge limit from the quick settings would be nice too, somewhat like this gnome extension

added to tasks

linkfrg · 2024-10-04T20:59:35Z

Issue: The service seems to get confused when there is 2 batteries, see below:
energy_rate:  10.204
energy_rate:  0
energy_rate:  10.204
energy_rate:  0
energy_rate:  10.204
energy_rate:  0
energy_rate:  10.204
energy_rate:  0
energy_rate:  10.204
energy_rate:  0
Edit: Thinkpads have 2 batteries, one being internal and one being external; /sys/class/power_supply/BAT0 and /sys/class/power_supply/BAT1 in order.

Only the energy_rate values differ?

From upower docs:

Amount of energy being drained from the source, measured in W. If positive, the source is being discharged, if negative it's being charged.

Maybe the power consumption is just not constant, so it drops to zero and rises back to 10.204

Munseer-am · 2024-10-05T07:25:27Z

The battery percentage displays correctly, and I have implemented the battery in the bar, but battery.charged and battery.charging don't seem to work properly; both return False, even though the upower command shows that the battery state is charging.

linkfrg · 2024-10-06T19:35:57Z

9caa6b4: Moved to UPowerGlib, also added support for managing multiple batteries, need testing.

There are two properties for BatteryService: devices and display_device.

devices (list[Battery]): list of all batteries
display_device (Battery): The battery to display (main battery?)

I will not describe all the properties for Battery, you can look at them directly in the code

artinmare · 2024-10-07T16:50:40Z

Hi, sorry I'm new to Linux and git in general so please pardon my clumsiness

First of all, love the work, I have been testing this and it seems to work fine for me. My laptop only have a single battery so cannot test for the multiple one, but everything else seems to be good

The only problem i found is the time_remaining prop which failed cause there is no self._charging attribute in Battery class. It seems to be a typo, I got it working by changing the self._charging to self.charging in the time_remaining function line 96 in the battery.py file.

Didn't know how to make a pull request so that's about it. I would report if I found another issues, love my experience with this software so far, thank you for creating it.

linkfrg · 2024-10-07T17:07:28Z

The only problem i found is the time_remaining prop which failed cause there is no self._charging attribute in Battery class. It seems to be a typo, I got it working by changing the self._charging to self.charging in the time_remaining function line 96 in the battery.py file.

fixed in faf4e41

…rvice to upower service

linkfrg · 2024-10-12T15:41:45Z

56ac88d
BREAKING CHANGE: BatteryService renamed to UPowerService.

Now this service has support for non battery devices.

In particular, batteries have been moved to the new property: batteries.

linkfrg · 2024-10-12T15:44:42Z

The only thing left is to test charge threshold

To check if your battery supports the charge threshold, use the UPowerDevice.charge_threshold_supported.

If True, enable it by setting charge_threshold property to True and try setting charge_start_threshold and charge_end_threshold

linkfrg · 2024-10-13T18:00:02Z

no activity :(

charge threshold support will be removed

initial

f48ea23

linkfrg mentioned this pull request Oct 3, 2024

Request to Add Battery Icon to Bar linkfrg/dotfiles#27

Closed

hotfix

f753012

fix?(battery service): call __sync() in init

87ea7d9

linkfrg added the enhancement New feature or request label Oct 3, 2024

linkfrg self-assigned this Oct 3, 2024

fix: allow change BusType for DBusProxy; use system bus type for batt…

4f09d4a

…ery service

fix(battery): self._available never set to True

d426567

dbus hotfix

2b8dcb0

linkfrg marked this pull request as draft October 5, 2024 04:24

linkfrg mentioned this pull request Oct 5, 2024

Some questions about DBus with Ignis #12

Closed

linkfrg added 2 commits October 7, 2024 00:26

feat(battery): move to UPowerGlib

9caa6b4

type fix

41b9e98

fix(battery): typo

faf4e41

linkfrg added 7 commits October 9, 2024 22:41

merge dbus.py from main branch

3cbd601

add Battery class to __all__ in __init__.py

41ecabd

add docs

9db9d08

feat(battery): add signals

902e6b6

update docs

61c6212

fix(battery): devices don't remove

35f9959

feat!(upower): add support for non battery devices; rename battery se…

56ac88d

…rvice to upower service

linkfrg changed the title ~~feat: add Battery Service~~ feat: add UPower Service Oct 12, 2024

battery: nuke charge threshold support

0efab39

linkfrg marked this pull request as ready for review October 13, 2024 18:00

linkfrg added 2 commits October 13, 2024 23:04

upstream dbus from main branch

7b4471b

remove org.freedesktop.UPower.Device.xml as unnecessary

7e2eb9d

linkfrg merged commit 4246898 into main Oct 13, 2024
4 checks passed

linkfrg deleted the feat/battery branch October 13, 2024 18:07

prakharn mentioned this pull request Oct 20, 2024

Battery bar does not update #24

Closed

2 tasks

TanR314 mentioned this pull request Nov 30, 2024

Battery charging property is not being updated #49

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add UPower Service #10

feat: add UPower Service #10

linkfrg commented Oct 3, 2024 •

edited

Loading

Munseer-am commented Oct 3, 2024

linkfrg commented Oct 3, 2024

Munseer-am commented Oct 3, 2024

linkfrg commented Oct 3, 2024 •

edited

Loading

Munseer-am commented Oct 3, 2024

linkfrg commented Oct 3, 2024

CGod-dev commented Oct 3, 2024

linkfrg commented Oct 3, 2024

Munseer-am commented Oct 3, 2024 •

edited

Loading

CGod-dev commented Oct 3, 2024 •

edited

Loading

linkfrg commented Oct 4, 2024

CGod-dev commented Oct 4, 2024

linkfrg commented Oct 4, 2024

CGod-dev commented Oct 4, 2024

linkfrg commented Oct 4, 2024 •

edited

Loading

dylanc24 commented Oct 4, 2024

CGod-dev commented Oct 4, 2024

linkfrg commented Oct 4, 2024

linkfrg commented Oct 4, 2024

CGod-dev commented Oct 4, 2024

linkfrg commented Oct 4, 2024

linkfrg commented Oct 4, 2024

linkfrg commented Oct 4, 2024

Munseer-am commented Oct 5, 2024 •

edited

Loading

linkfrg commented Oct 6, 2024 •

edited

Loading

artinmare commented Oct 7, 2024

linkfrg commented Oct 7, 2024

linkfrg commented Oct 12, 2024

linkfrg commented Oct 12, 2024 •

edited

Loading

linkfrg commented Oct 13, 2024

feat: add UPower Service #10

feat: add UPower Service #10

Conversation

linkfrg commented Oct 3, 2024 • edited Loading

Munseer-am commented Oct 3, 2024

linkfrg commented Oct 3, 2024

Munseer-am commented Oct 3, 2024

linkfrg commented Oct 3, 2024 • edited Loading

Munseer-am commented Oct 3, 2024

linkfrg commented Oct 3, 2024

CGod-dev commented Oct 3, 2024

linkfrg commented Oct 3, 2024

Munseer-am commented Oct 3, 2024 • edited Loading

CGod-dev commented Oct 3, 2024 • edited Loading

linkfrg commented Oct 4, 2024

CGod-dev commented Oct 4, 2024

linkfrg commented Oct 4, 2024

CGod-dev commented Oct 4, 2024

linkfrg commented Oct 4, 2024 • edited Loading

dylanc24 commented Oct 4, 2024

CGod-dev commented Oct 4, 2024

linkfrg commented Oct 4, 2024

linkfrg commented Oct 4, 2024

CGod-dev commented Oct 4, 2024

linkfrg commented Oct 4, 2024

linkfrg commented Oct 4, 2024

linkfrg commented Oct 4, 2024

Munseer-am commented Oct 5, 2024 • edited Loading

linkfrg commented Oct 6, 2024 • edited Loading

artinmare commented Oct 7, 2024

linkfrg commented Oct 7, 2024

linkfrg commented Oct 12, 2024

linkfrg commented Oct 12, 2024 • edited Loading

linkfrg commented Oct 13, 2024

linkfrg commented Oct 3, 2024 •

edited

Loading

linkfrg commented Oct 3, 2024 •

edited

Loading

Munseer-am commented Oct 3, 2024 •

edited

Loading

CGod-dev commented Oct 3, 2024 •

edited

Loading

linkfrg commented Oct 4, 2024 •

edited

Loading

Munseer-am commented Oct 5, 2024 •

edited

Loading

linkfrg commented Oct 6, 2024 •

edited

Loading

linkfrg commented Oct 12, 2024 •

edited

Loading