proxy: v2.171.0 #7661
Merged
proxy: v2.171.0 #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release adds a new configuration variable, `LINKERD2_PROXY_ACCESS_LOG` that configures whether per-request access logs are emitted from inbound HTTP proxies. This variable may be set to `apache` for Apache Common Log output or `json` for JSON formatted logs. Access logs are emitted to stderr and the proxy's diagnostics logs are emitted to stdout. --- * build(deps): bump h2 from 0.3.9 to 0.3.10 (linkerd/linkerd2-proxy#1430) * Update Rust to v1.56.1 (linkerd/linkerd2-proxy#1431) * build(deps): bump indexmap from 1.7.0 to 1.8.0 (linkerd/linkerd2-proxy#1433) * Add a devcontainer config (linkerd/linkerd2-proxy#1432) * build(deps): bump serde_json from 1.0.74 to 1.0.75 (linkerd/linkerd2-proxy#1436) * build(deps): bump tracing-subscriber from 0.3.5 to 0.3.6 (linkerd/linkerd2-proxy#1435) * test: remove `env::set_var` call in test logging initialization (linkerd/linkerd2-proxy#1437) * trace: Apache Common Log Format access logging (linkerd/linkerd2-proxy#1319) * build(deps): bump libc from 0.2.112 to 0.2.113 (linkerd/linkerd2-proxy#1438) * build(deps): bump socket2 from 0.4.2 to 0.4.3 (linkerd/linkerd2-proxy#1439) * access-log: Add JSON support (linkerd/linkerd2-proxy#1350)
alpeb
approved these changes
Jan 21, 2022
hawkw
added a commit
that referenced
this pull request
Jan 24, 2022
With #7661, the proxy supports a `LINKERD2_PROXY_ACCESS_LOG` configuration with the values `apache` or `json`. This configuration causes the proxy to emit access logs to stderr. This branch makes it possible for users to enable access logging by adding an annotation, `config.linkerd.io/access-log`, that tells the proxy injector to set this environment variable. I've also added some tests to ensure that the annotation and the environment variable are set correctly. I tried to follow the existing tests as examples of how we do this, but please let me know if I've overlooked anything! Closes #7662 #1913 Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release adds a new configuration variable,
LINKERD2_PROXY_ACCESS_LOGthat configures whether per-request accesslogs are emitted from inbound HTTP proxies. This variable may be set to
apachefor Apache Common Log output orjsonfor JSON formatted logs.Access logs are emitted to stderr and the proxy's diagnostics logs are
emitted to stdout.
env::set_varcall in test logging initialization (test: removeenv::set_varcall in test logging initialization linkerd2-proxy#1437)