Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge-20.7.4 #4785

Merged
merged 4 commits into from
Jul 23, 2020
Merged

edge-20.7.4 #4785

merged 4 commits into from
Jul 23, 2020

Conversation

zaharidichev
Copy link
Member

@zaharidichev zaharidichev commented Jul 23, 2020

edge-20.7.4

This edge release adds support for the new Kubernetes
EndpointSlice
resource to the Destination controller. Using the EndpointSlice API is more
efficient for the Kubernetes control plane than using the Endpoints API. If
the cluster supports EndpointSlices (a beta feature in Kubernetes 1.17),
Linkerd can be installed with --enable-endpoint-slices flag to use this
resource rather than the Endpoints API.

  • Added fish shell completions to the linkerd command (thanks @WLun001!)
  • Enabled the support for EndpointSlices (thanks @Matei207!)
  • Separated Prometheus checks and made them runnable only when the add-on
    is enabled

Signed-off-by: Zahari Dichev [email protected]

Signed-off-by: Zahari Dichev <[email protected]>
@zaharidichev zaharidichev requested a review from a team July 23, 2020 17:57
CHANGES.md Outdated

* Added fish shell completions to the `linkerd` command (thanks @WLun001!)
* Enabled the support for EndpointSlices (thanks @Matei207!)
* Separated prometheus checks and made them runnable only when there the add-on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have an extra "there" in here:

"Separated prometheus checks and made them runnable only when the add-on is enabled"

Signed-off-by: Zahari Dichev <[email protected]>
@zaharidichev zaharidichev requested a review from admc July 23, 2020 18:24
CHANGES.md Outdated
@@ -1,5 +1,14 @@
# Changes

## edge-20.7.4

This edge release brings support for EndpointSlices.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to have a little more discussion of what endpoint slices are, what this change means for the user, etc. Maybe:

Suggested change
This edge release brings support for EndpointSlices.
This edge release adds support for the new Kubernetes [EndpointSlice] resource to
the Destination controller. Using the EndpointSlice API is more efficient for the
Kubernetes control plane than using the Endpoints API. If the cluster supports
EndpointSlices (a beta feature in Kubernetes 1.17), Linkerd can be installed with
```console
linkerd install --enable-endpoint-slices

to use this resource rather than the Endpoints API.

EndpointSlice

Signed-off-by: Zahari Dichev <[email protected]>
Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things. Once they're addressed, this looks great to me!

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Signed-off-by: Zahari Dichev <[email protected]>
Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful, lgtm!

@zaharidichev zaharidichev merged commit 76f73a2 into main Jul 23, 2020
@zaharidichev zaharidichev deleted the zd/edge-20.7.4 branch July 23, 2020 19:46
han-so1omon pushed a commit to han-so1omon/linkerd2 that referenced this pull request Jul 28, 2020
## edge-20.7.4

This edge release adds support for the new Kubernetes [EndpointSlice] resource
to the Destination controller. Using the EndpointSlice API is more efficient
for the Kubernetes control plane than using the Endpoints API. If the cluster
supports EndpointSlices (a beta feature in Kubernetes 1.17), Linkerd can be
installed with `--enable-endpoint-slices` flag to use this resource rather
than the Endpoints API.

* Added fish shell completions to the `linkerd` command (thanks @WLun001!)
* Enabled the support for EndpointSlices (thanks @Matei207!)
* Separated prometheus checks and made them runnable only when the add-on
  is enabled

Signed-off-by: Zahari Dichev <[email protected]>
han-so1omon pushed a commit to han-so1omon/linkerd2 that referenced this pull request Jul 28, 2020
## edge-20.7.4

This edge release adds support for the new Kubernetes [EndpointSlice] resource
to the Destination controller. Using the EndpointSlice API is more efficient
for the Kubernetes control plane than using the Endpoints API. If the cluster
supports EndpointSlices (a beta feature in Kubernetes 1.17), Linkerd can be
installed with `--enable-endpoint-slices` flag to use this resource rather
than the Endpoints API.

* Added fish shell completions to the `linkerd` command (thanks @WLun001!)
* Enabled the support for EndpointSlices (thanks @Matei207!)
* Separated prometheus checks and made them runnable only when the add-on
  is enabled

Signed-off-by: Zahari Dichev <[email protected]>
Signed-off-by: Eric Solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants