bin: shellscript housekeeping #13469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use single quotes for static strings, not double - Use sh and not bash for _os.sh that has no bash-specific content - Remove superfluous double quotes on variable assignments - Only use bash-specific [[ ]] if statements for bash-specific content - Consistently use style with if; then on same line Change-Id: I1575971262773149db32021efbf2d7f1d4df9771 Signed-off-by: Joakim Roubert <[email protected]>
alpeb
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Glad to hear back from you @joakimr-axis, this lookgs great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joakim Roubert [email protected]