Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix docker build warnings #13351

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

DerekTBrown
Copy link
Contributor

Commit Message:

    lint: fix docker build warnings
    
    Docker builds emit a warning because the case of 'FROM' and 'as' don't match. Fix this everywhere.
    
    Signed-off-by: Derek Brown <[email protected]>

Context:

When running Docker builds, I see the following warning:

 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)     
...                                                                                                                                                    
 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 27)    

Fix this pattern everywhere.

Docker builds emit a warning because the case of 'FROM' and 'as' don't match. Fix this everywhere.

Signed-off-by: Derek Brown <[email protected]>
@DerekTBrown DerekTBrown requested a review from a team as a code owner November 19, 2024 19:29
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DerekTBrown , this looks good to me!

@alpeb alpeb merged commit 80e444e into linkerd:main Nov 20, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants