Upgrade to client-go 0.30.0 #12463
Merged
Upgrade to client-go 0.30.0 #12463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
olix0r
approved these changes
Apr 18, 2024
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Alex Leong <[email protected]> Signed-off-by: Mark S <[email protected]>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 22, 2024
Signed-off-by: Alex Leong <[email protected]> Signed-off-by: Mark S <[email protected]>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Alex Leong <[email protected]> Signed-off-by: Mark S <[email protected]>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Alex Leong <[email protected]> Signed-off-by: Mark S <[email protected]>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Alex Leong <[email protected]> Signed-off-by: Mark S <[email protected]>
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Alex Leong <[email protected]> Signed-off-by: Mark S <[email protected]>
klingerf
added a commit
to klingerf/linkerd2
that referenced
this pull request
Apr 30, 2024
We use the `kube_codegen.sh` script from the kubernetes/code-generator repo to generate Go bindings for CRDs defined in this repo. The arguments and flags for that script changed in Kubernetes 1.30, which broke our usage of that script when this repo's Kubernetes dependencies were updated in linkerd#12463. In this change, I'm updating `bin/update-codegen.sh` to work with the latest version of the `kube_codegen.sh` script. To validate, check out this branch and run `bin/update-codegen.sh`. The script should exit cleanly, and there should be no changes to the previously-generated Go bindings. Signed-off-by: Kevin Ingelman <[email protected]>
olix0r
pushed a commit
that referenced
this pull request
Apr 30, 2024
We use the `kube_codegen.sh` script from the kubernetes/code-generator repo to generate Go bindings for CRDs defined in this repo. The arguments and flags for that script changed in Kubernetes 1.30, which broke our usage of that script when this repo's Kubernetes dependencies were updated in #12463. In this change, I'm updating `bin/update-codegen.sh` to work with the latest version of the `kube_codegen.sh` script. To validate, check out this branch and run `bin/update-codegen.sh`. The script should exit cleanly, and there should be no changes to the previously-generated Go bindings. Signed-off-by: Kevin Ingelman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades client-go related deps to v0.30.0. This also requires specifying the go version explicitly at 1.22.0.