Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL check with go v1.22 #12183

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix CodeQL check with go v1.22 #12183

merged 1 commit into from
Mar 1, 2024

Conversation

alpeb
Copy link
Member

@alpeb alpeb commented Feb 29, 2024

The CodeQL check for go started failing (sporadically) after upgrading to go v1.22, with "go: download go1.22 for linux/amd64: toolchain not available":
https://github.com/linkerd/linkerd2/actions/runs/8071751074/job/22142449967?pr=12167#step:4:89

A previous successful run recommended using actions/setup-go:

The go.mod file requires version v1.22 of Go, but version v1.20.14 is installed. Consider adding an actions/setup-go step to your workflow.
https://github.com/linkerd/linkerd2/actions/runs/8066300149/job/22034010793#step:4:88

So this is exactly what we do here.

@alpeb alpeb force-pushed the alpeb/fix-codeql-go1.22 branch from 34c2d8a to aef6a9d Compare February 29, 2024 20:16
@alpeb alpeb requested a review from a team as a code owner February 29, 2024 20:16
@alpeb alpeb force-pushed the alpeb/fix-codeql-go1.22 branch from aef6a9d to 2d888b8 Compare February 29, 2024 20:18
@alpeb alpeb changed the title wip: fix codeql with go v1.22 Fix CodeQL with go v1.22 Feb 29, 2024
@alpeb alpeb changed the title Fix CodeQL with go v1.22 Fix CodeQL check with go v1.22 Feb 29, 2024
@alpeb alpeb merged commit 3d331d7 into main Mar 1, 2024
6 checks passed
@alpeb alpeb deleted the alpeb/fix-codeql-go1.22 branch March 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants